Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate repository settings #7096

Closed
dadoonet opened this issue Jul 30, 2014 · 1 comment
Closed

Validate repository settings #7096

dadoonet opened this issue Jul 30, 2014 · 1 comment
Assignees
@imotov
Labels
>enhancement v1.4.0 v2.0.0-beta1

Comments

@dadoonet
Copy link
Member

As discussed in elastic/elasticsearch-cloud-azure#21, we need to let plugins validate repository settings.

So BlobStoreRepository could have a new protected method which could be overloaded by plugins or repository implementations, such as:

void validateRepositorySettings() throws RepositoryException;
@dadoonet dadoonet mentioned this issue Jul 30, 2014
Closed
@dadoonet dadoonet mentioned this issue Aug 13, 2014
Closed
@imotov imotov mentioned this issue Aug 20, 2014
Closed
@clintongormley clintongormley reopened this Sep 8, 2014
@s1monw
Copy link
Contributor

s1monw commented Sep 10, 2014

@imotov I see a commit referenced here - didn't make it to a PR? Can you either push to 1.5 or open a PR?

@imotov imotov mentioned this issue Sep 11, 2014
Closed
@imotov imotov mentioned this issue Sep 23, 2014
Closed
imotov added a commit to imotov/elasticsearch that referenced this issue Oct 7, 2014
@imotov
[SNAPSHOT] Add repository validation
286b603 
Fixes elastic#7096
imotov added a commit that referenced this issue Oct 7, 2014
@imotov
[SNAPSHOT] Add repository validation
800b0e2 
Fixes #7096
@imotov imotov closed this as completed in 555bfcb Oct 7, 2014
imotov added a commit that referenced this issue Oct 7, 2014
@imotov
[SNAPSHOT] Add repository validation
dd64955 
Fixes #7096
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@imotov
[SNAPSHOT] Add repository validation
ccfcce8 
Fixes elastic#7096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imotov imotov

Labels
>enhancement v1.4.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add repository validation imotov/elasticsearch
4 participants
@clintongormley @dadoonet @imotov @s1monw