Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick one: ModelSecretsTests testEqualsAndHashcode is too flaky: a random (fake) api-key of 1 has a too high chance of colliding (see https://gradle-enterprise.elastic.co/s/hrlw444sgiia6/tests/task/:x-pack:plugin:inference:test/details/org.elasticsearch.xpack.inference.ModelSecretsTests/testEqualsAndHashcode?top-execution=1 for a failure); besides, such a short key is irrealistic.