Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Reenable another csv test #100411

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Oct 6, 2023

This one was also disabled as part of our effort to do Block tracking and now it passes. I believe it was disabled when we didn't close Blocks on the way into EVAL. But now we do, so we're good to enable this one!

This one was also disabled as part of our effort to do Block tracking
and now it passes. I believe it was disabled when we didn't close Blocks
on the way into `EVAL`. But now we do, so we're good to enable this one!
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nik9000 nik9000 added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge labels Oct 6, 2023
@elasticsearchmachine elasticsearchmachine merged commit 8b9d413 into elastic:main Oct 6, 2023
@nik9000 nik9000 deleted the esql_csv_reenable_123 branch October 6, 2023 16:34
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Oct 6, 2023
This one was also disabled as part of our effort to do Block tracking
and now it passes. I believe it was disabled when we didn't close Blocks
on the way into `EVAL`. But now we do, so we're good to enable this one!
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.11

elasticsearchmachine pushed a commit that referenced this pull request Oct 6, 2023
This one was also disabled as part of our effort to do Block tracking
and now it passes. I believe it was disabled when we didn't close Blocks
on the way into `EVAL`. But now we do, so we're good to enable this one!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue Team:QL (Deprecated) Meta label for query languages team v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants