-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESQL: Reenable another csv test #100411
Merged
elasticsearchmachine
merged 2 commits into
elastic:main
from
nik9000:esql_csv_reenable_123
Oct 6, 2023
Merged
ESQL: Reenable another csv test #100411
elasticsearchmachine
merged 2 commits into
elastic:main
from
nik9000:esql_csv_reenable_123
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one was also disabled as part of our effort to do Block tracking and now it passes. I believe it was disabled when we didn't close Blocks on the way into `EVAL`. But now we do, so we're good to enable this one!
elasticsearchmachine
added
the
Team:QL (Deprecated)
Meta label for query languages team
label
Oct 6, 2023
Pinging @elastic/es-ql (Team:QL) |
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
bpintea
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
nik9000
added
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
auto-backport-and-merge
labels
Oct 6, 2023
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Oct 6, 2023
This one was also disabled as part of our effort to do Block tracking and now it passes. I believe it was disabled when we didn't close Blocks on the way into `EVAL`. But now we do, so we're good to enable this one!
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
>non-issue
Team:QL (Deprecated)
Meta label for query languages team
v8.11.0
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was also disabled as part of our effort to do Block tracking and now it passes. I believe it was disabled when we didn't close Blocks on the way into
EVAL
. But now we do, so we're good to enable this one!