Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Use correct writable name for model assignment metadata in mixed cluster #100886

Merged
merged 4 commits into from
Oct 16, 2023
Merged

[ML] Use correct writable name for model assignment metadata in mixed cluster #100886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e824073
Always
davidkyle Oct 16, 2023
679e789
Update docs/changelog/100886.yaml
davidkyle Oct 16, 2023
820ab59
Update docs/changelog/100886.yaml
davidkyle Oct 16, 2023
5861ac9
Update docs/changelog/100886.yaml
davidkyle Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/100886.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 100886
summary: Use the correct writable name for model assignment metadata in mixed version clusters. Prevents a node failure due to IllegalArgumentException Unknown NamedWriteable [trained_model_assignment]
area: Machine Learning
type: bug
issues: []
3 changes: 2 additions & 1 deletion .../java/org/elasticsearch/xpack/ml/inference/assignment/TrainedModelAssignmentMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,8 @@ private TrainedModeAssignmentDiff(final StreamInput in, String writeableName) th
@Override
public Metadata.Custom apply(Metadata.Custom part) {
return new TrainedModelAssignmentMetadata(
new TreeMap<>(modelRoutingEntries.apply(((TrainedModelAssignmentMetadata) part).deploymentRoutingEntries))
new TreeMap<>(modelRoutingEntries.apply(((TrainedModelAssignmentMetadata) part).deploymentRoutingEntries)),
writeableName
);
}

Expand Down