SQL: Use new testing framework #101774
Merged
SQL: Use new testing framework #101774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not obtain node addresses directly from global property - use getTestRestCluster instead. This is non-static, which requires refactoring.
alex-spies
commented
Nov 13, 2023
| * dependencies but we don't really want them because they cause | ||
| * all kinds of trouble with the jar hell checks. So we suppress | ||
| * them explicitly for non-es projects. */ | ||
| javaRestTestImplementation(project(':x-pack:plugin:sql:qa:server')) { |
There was a problem hiding this comment.
Nothing below this line is new - only fixed indentation (was tripping me up, haha).
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
@elasticsearchmachine run Check labels |
luigidellaquila
approved these changes
Nov 13, 2023
...rver/security/src/test/java/org/elasticsearch/xpack/sql/qa/security/SqlSecurityTestCase.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the following test suites from
legacy-java-rest-testtointernal-java-rest-test:x-pack/plugin/sql/qa/server/:single-nodemulti-nodemulti-cluster-with-securityMain changes:
build.gradlefiles.TestRules), one each forsingle-node,multi-nodeandmulti-cluster-with-security.A large part of the changes are mechanical.