-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add prefix strings option to trained models #102089
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>
Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>
# Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/inference/TrainedModelConfig.java
davidkyle
added
>enhancement
:ml
Machine learning
cloud-deploy
Publish cloud docker image for Cloud-First-Testing
v8.12.0
labels
Nov 13, 2023
Documentation preview: |
Pinging @elastic/ml-core (Team:ML) |
Hi @davidkyle, I've created a changelog YAML for you. |
droberts195
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
szabosteve
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 2
@elasticmachine update branch |
This was referenced Dec 8, 2023
davidkyle
added a commit
to elastic/elasticsearch-specification
that referenced
this pull request
Jan 2, 2024
The prefix_strings option was added to support the E5 model in elastic/elasticsearch#102089
davidkyle
added a commit
to elastic/elasticsearch-specification
that referenced
this pull request
Mar 13, 2024
The prefix_strings option was added to support the E5 model in elastic/elasticsearch#102089
pquentin
pushed a commit
to elastic/elasticsearch-specification
that referenced
this pull request
Mar 14, 2024
* Add prefix_string config option for ML models (#2363) The prefix_strings option was added to support the E5 model in elastic/elasticsearch#102089 * Add prefix_strings option to PUT model request (#2449) Follow up to #2363 where prefix_strings option was added to TrainedModelConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cloud-deploy
Publish cloud docker image for Cloud-First-Testing
>enhancement
:ml
Machine learning
Team:ML
Meta label for the ML team
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised in place of #101978
Certain NLP models such as multilingual-e5-large require a prefix string to be applied to the input text. For asymmetric tasks such as information retrieval the prefix can be different when ingesting the data and when searching it. For example text embedding model can have a one prefix applied when the model is evaluated as part of an knn search and a different prefix when ingesting documents.
An example model configuration with prefix strings is:
Many files have been touched by this change but the bulk of the work is quite simple: define the configuration object an pass the prefix type (context) parameter down the inference calls.