Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rrf.asciidoc #103078

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Update rrf.asciidoc #103078

merged 1 commit into from
Dec 7, 2023

Conversation

ugosan
Copy link
Contributor

@ugosan ugosan commented Dec 6, 2023

typo

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

@ugosan please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.11.2 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 6, 2023
@abdonpijpelink abdonpijpelink added >docs General docs changes and removed needs:triage Requires assignment of a team area label labels Dec 7, 2023
@abdonpijpelink abdonpijpelink self-assigned this Dec 7, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Dec 7, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

abdonpijpelink
abdonpijpelink approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @ugosan !

@abdonpijpelink abdonpijpelink merged commit 851cab6 into 8.11 Dec 7, 2023
8 checks passed
@abdonpijpelink abdonpijpelink deleted the ugosan-patch-1 branch December 7, 2023 09:55
This was referenced Dec 7, 2023
Merged
Merged
abdonpijpelink pushed a commit to abdonpijpelink/elasticsearch that referenced this pull request Dec 7, 2023
@ugosan
Update rrf.asciidoc (elastic#103078)
ce98341 
typo

(cherry picked from commit 851cab6)
@abdonpijpelink
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ main
✅ 8.12

Questions ?

Please refer to the Backport tool documentation

abdonpijpelink pushed a commit to abdonpijpelink/elasticsearch that referenced this pull request Dec 7, 2023
@ugosan
Update rrf.asciidoc (elastic#103078)
34a612e 
typo

(cherry picked from commit 851cab6)
abdonpijpelink added a commit that referenced this pull request Dec 11, 2023
@abdonpijpelink @ugosan
Update rrf.asciidoc (#103078) (#103110)
d1c6d27 
typo

(cherry picked from commit 851cab6)

Co-authored-by: Ugo Sangiorgi <ugo.sangiorgi@elastic.co>
abdonpijpelink added a commit that referenced this pull request Dec 11, 2023
@abdonpijpelink @ugosan
Update rrf.asciidoc (#103078) (#103109)
6b60a53 
typo

(cherry picked from commit 851cab6)

Co-authored-by: Ugo Sangiorgi <ugo.sangiorgi@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdonpijpelink abdonpijpelink abdonpijpelink approved these changes

Assignees

@abdonpijpelink abdonpijpelink

Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ugosan @elasticsearchmachine @abdonpijpelink @brianseeders