Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] Ensure dynamicMapping updates are handled in insertion order (#103047) #103083

Merged

Conversation

benwtrent
Copy link
Member

Backports the following commits to 8.11:

…#103047)

The switch to holding dynamic fields in a hashmap effectively randomizes their iteration order. This can be troublesome when building the mapping update required by these updates. When iterating in an unknown order, recursing to the leaf mapper can occur many times `O(n^2)`. However, starting with insertion order, it will occur only `O(n)` times.

closes: elastic#103011
@benwtrent benwtrent added :Search Foundations/Mapping Index mappings, including merging and defining field types >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Search Meta label for search team labels Dec 6, 2023
@elasticsearchmachine elasticsearchmachine merged commit 3aa6a57 into elastic:8.11 Dec 6, 2023
14 checks passed
@benwtrent benwtrent deleted the backport/8.11/pr-103047 branch December 6, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v8.11.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants