Use dataset size instead of on-disk size for data stream stats #103342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using the size of the shard that was on local disk, however, in some cases (for object storage) this would return 0b, which is very confusing. This commit changes it to use the dataset size, which should be calculated regardless of where the data resides.
dakrone
added
>bug
:Data Management/Data streams
|
Hi @dakrone, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
andreidan
approved these changes
Dec 12, 2023
dakrone
added
auto-merge-without-approval
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Dec 12, 2023
…ic#103342) Previously we were using the size of the shard that was on local disk, however, in some cases (for object storage) this would return 0b, which is very confusing. This commit changes it to use the dataset size, which should be calculated correctly regardless of where the data resides.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2023
…) (#103345) Previously we were using the size of the shard that was on local disk, however, in some cases (for object storage) this would return 0b, which is very confusing. This commit changes it to use the dataset size, which should be calculated correctly regardless of where the data resides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using the size of the shard that was on local disk, however, in some cases (for object storage) this would return 0b, which is very confusing. This commit changes it to use the dataset size, which should be calculated correctly regardless of where the data resides.