-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingest correctly handle upsert operations and drop processors together #104585
Ingest correctly handle upsert operations and drop processors together #104585
Commits on Jan 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0c4795a - Browse repository at this point
Copy the full SHA 0c4795aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bdcca3 - Browse repository at this point
Copy the full SHA 1bdcca3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ec31a4 - Browse repository at this point
Copy the full SHA 9ec31a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7722cb2 - Browse repository at this point
Copy the full SHA 7722cb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5b6b49 - Browse repository at this point
Copy the full SHA d5b6b49View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2225ba - Browse repository at this point
Copy the full SHA f2225baView commit details -
Tighten up the failure side, too
It doesn't invoke new ShardId(...) which is where the exception was, but it's still nice to report this information if we have it (which we do!).
Configuration menu - View commit details
-
Copy full SHA for 18cb954 - Browse repository at this point
Copy the full SHA 18cb954View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8af303c - Browse repository at this point
Copy the full SHA 8af303cView commit details -
Swap the order of these methods
Failure is so much more normal/expected than dropping, so let's have that one first. Also it has a better explanation of what's going on and why, which I like having earlier (but don't want to duplicate).
Configuration menu - View commit details
-
Copy full SHA for ed4832f - Browse repository at this point
Copy the full SHA ed4832fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ecbdd7 - Browse repository at this point
Copy the full SHA 6ecbdd7View commit details -
Increasing the symmetry between markItemAsFailed and markItemAsDropped.
Configuration menu - View commit details
-
Copy full SHA for 5872ce1 - Browse repository at this point
Copy the full SHA 5872ce1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29ce3c6 - Browse repository at this point
Copy the full SHA 29ce3c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac1362b - Browse repository at this point
Copy the full SHA ac1362bView commit details -
Revert "Temporarily blow away the new tests and add asserts"
This reverts commit 29ce3c6.
Configuration menu - View commit details
-
Copy full SHA for 9e02a41 - Browse repository at this point
Copy the full SHA 9e02a41View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1739e7 - Browse repository at this point
Copy the full SHA a1739e7View commit details
Commits on Jan 26, 2024
-
Add a test for fail with _update
This requires that we have a default_pipeline in place, so I've also extended the cleanup to include deleting the index -- otherwise if something goes wrong the cleanup can fail because you can't drop a pipeline if there's an index using it.
Configuration menu - View commit details
-
Copy full SHA for dcd6115 - Browse repository at this point
Copy the full SHA dcd6115View commit details -
The response will be an UpdateResponse (not an IndexResponse) when a document is dropped on an upsert, both of those are a DocWriteResponse.
Configuration menu - View commit details
-
Copy full SHA for e3eac86 - Browse repository at this point
Copy the full SHA e3eac86View commit details -
Add a test for drop with _update
This requires that we have a default_pipeline in place, so I've also extended the cleanup to include deleting the index -- otherwise if something goes wrong the cleanup can fail because you can't drop a pipeline if there's an index using it.
Configuration menu - View commit details
-
Copy full SHA for 3d949bd - Browse repository at this point
Copy the full SHA 3d949bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for f24d38a - Browse repository at this point
Copy the full SHA f24d38aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ecf354 - Browse repository at this point
Copy the full SHA 3ecf354View commit details