Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest correctly handle upsert operations and drop processors together #104585

Merged
merged 20 commits into from
Jan 29, 2024

Commits on Jan 20, 2024

  1. Whitespace

    joegallo committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    0c4795a View commit details
    Browse the repository at this point in the history
  2. More whitespace

    joegallo committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    1bdcca3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ec31a4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7722cb2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d5b6b49 View commit details
    Browse the repository at this point in the history
  6. Add another failing test

    joegallo committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    f2225ba View commit details
    Browse the repository at this point in the history
  7. Tighten up the failure side, too

    It doesn't invoke new ShardId(...) which is where the exception was,
    but it's still nice to report this information if we have it (which we
    do!).
    joegallo committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    18cb954 View commit details
    Browse the repository at this point in the history
  8. Rename this constant

    joegallo committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    8af303c View commit details
    Browse the repository at this point in the history
  9. Swap the order of these methods

    Failure is so much more normal/expected than dropping, so let's have
    that one first. Also it has a better explanation of what's going on
    and why, which I like having earlier (but don't want to duplicate).
    joegallo committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    ed4832f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6ecbdd7 View commit details
    Browse the repository at this point in the history
  11. Tidy this up a bit

    Increasing the symmetry between markItemAsFailed and
    markItemAsDropped.
    joegallo committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    5872ce1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    29ce3c6 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ac1362b View commit details
    Browse the repository at this point in the history
  14. Revert "Temporarily blow away the new tests and add asserts"

    This reverts commit 29ce3c6.
    joegallo committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    9e02a41 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    a1739e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Add a test for fail with _update

    This requires that we have a default_pipeline in place, so I've also
    extended the cleanup to include deleting the index -- otherwise if
    something goes wrong the cleanup can fail because you can't drop a
    pipeline if there's an index using it.
    joegallo committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    dcd6115 View commit details
    Browse the repository at this point in the history
  2. Widen this type

    The response will be an UpdateResponse (not an IndexResponse) when a
    document is dropped on an upsert, both of those are a
    DocWriteResponse.
    joegallo committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e3eac86 View commit details
    Browse the repository at this point in the history
  3. Add a test for drop with _update

    This requires that we have a default_pipeline in place, so I've also
    extended the cleanup to include deleting the index -- otherwise if
    something goes wrong the cleanup can fail because you can't drop a
    pipeline if there's an index using it.
    joegallo committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    3d949bd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f24d38a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3ecf354 View commit details
    Browse the repository at this point in the history