-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transform] Fail checkpoint on missing clusters #106793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are no remote or local clusters for a given source index, we call the listener's `onFailure` method with a `CheckpointException`. A running transform will fail and retry, eventually moving into an unhealthy and failed state. Any call to the stats API will note the checkpoint failure and return. This fixes a timeout issue calling the Transform stats API and prevents the Transform from being stuck in indexing. Fix elastic#106790 Fix elastic#104533
prwhelan
added
>bug
:ml/Transform
Transform
Team:ML
Meta label for the ML team
v8.14.0
labels
Mar 26, 2024
Pinging @elastic/ml-core (Team:ML) |
Hi @prwhelan, I've created a changelog YAML for you. |
...rm/src/main/java/org/elasticsearch/xpack/transform/checkpoint/DefaultCheckpointProvider.java
Show resolved
Hide resolved
...rm/src/main/java/org/elasticsearch/xpack/transform/checkpoint/DefaultCheckpointProvider.java
Outdated
Show resolved
Hide resolved
...rm/src/main/java/org/elasticsearch/xpack/transform/checkpoint/DefaultCheckpointProvider.java
Outdated
Show resolved
Hide resolved
przemekwitek
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Backport successful
|
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Mar 27, 2024
When there are no remote or local clusters for a given source index, we call the listener's `onFailure` method with a `CheckpointException`. A running transform will fail and retry, eventually moving into an unhealthy and failed state. Any call to the stats API will note the checkpoint failure and return. This fixes a timeout issue calling the Transform stats API and prevents the Transform from being stuck in indexing. Fix elastic#106790 Fix elastic#104533
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 27, 2024
When there are no remote or local clusters for a given source index, we call the listener's `onFailure` method with a `CheckpointException`. A running transform will fail and retry, eventually moving into an unhealthy and failed state. Any call to the stats API will note the checkpoint failure and return. This fixes a timeout issue calling the Transform stats API and prevents the Transform from being stuck in indexing. Fix #106790 Fix #104533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no remote or local clusters for a given source index, we call the listener's
onFailure
method with aCheckpointException
. A running transform will fail and retry, eventually moving into an unhealthy and failed state. Any call to the stats API will note the checkpoint failure and return.This fixes a timeout issue calling the Transform stats API and prevents the Transform from being stuck in indexing.
Fix #106790
Fix #104533