Make the GeoIpCache more generic #113053
Merged
Make the GeoIpCache more generic #113053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it can handle any response type, rather than being AbstractResponse -specific.
joegallo
added
>non-issue
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
💚 Backport successful
|
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
Sep 18, 2024
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Sep 18, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the cache can handle any response type, rather than being
AbstractResponse-specific.#113045 makes the core MMDB object the
Reader, but a reader can return responses of various object types, not justAbstractResponses. In order to match the new lower level constructs we're using here, the cache should work with any oldObject.