Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TSDB doc_values utils for use in the new codec #115042

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Oct 17, 2024

This PR refactors the doc_values utils used in the TSDB codec to allow sharing between the current codec and the new codec.

@dnhatn dnhatn changed the title Refactor TSDB doc_values util allow introduce new codec Refactor tsdb doc_values utils allow introduce new codec Oct 17, 2024
@dnhatn dnhatn changed the title Refactor tsdb doc_values utils allow introduce new codec Refactor TSDB doc_values utils for use in the new codec Oct 18, 2024
@dnhatn dnhatn marked this pull request as ready for review October 18, 2024 02:56
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Oct 18, 2024

Thanks @martijnvg.

@dnhatn dnhatn merged commit d0c8ff5 into elastic:main Oct 18, 2024
16 checks passed
@dnhatn dnhatn deleted the shared-doc-values-util branch October 18, 2024 15:01
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Oct 18, 2024
This PR refactors the doc_values utils used in the TSDB codec to allow
sharing between the current codec and the new codec.
elasticsearchmachine pushed a commit that referenced this pull request Oct 19, 2024
…15159)

This PR refactors the doc_values utils used in the TSDB codec to allow
sharing between the current codec and the new codec.
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
This PR refactors the doc_values utils used in the TSDB codec to allow 
sharing between the current codec and the new codec.
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
This PR refactors the doc_values utils used in the TSDB codec to allow 
sharing between the current codec and the new codec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants