Optimize IndexTemplateRegistry#clusterChanged #115347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The streaming code in these loops is hot enough to show up in a flamegraph, unrolling them isn't significantly less readable and it is faster.
joegallo
added
:Data Management/Indices APIs
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
approved these changes
Oct 22, 2024
joegallo
added
the
auto-backport
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Oct 22, 2024
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 23, 2024
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Oct 23, 2024
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The streaming code in these loops is hot enough to show up in a flamegraph, unrolling them isn't significantly less readable and it is faster.
Note: I'm optimizing the
GeoIpDownloaderTaskExecutor#clusterChanged(coming in a future PR) and this jumped out at me in the flamegraphs as something nearby that was easy enough to improve while I was in the area.