Update synthetic source legacy license cutoff date. #117658
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update default cutoff date from 12-12-2024T00:00 UTC to 01-02-2025T00:00 UTC.
martijnvg
added
>non-issue
auto-backport
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
n1v0lg
approved these changes
Nov 27, 2024
| @@ -29,7 +29,7 @@ final class SyntheticSourceLicenseService { | |||
| // You can only override this property if you received explicit approval from Elastic. | |||
| static final String CUTOFF_DATE_SYS_PROP_NAME = "es.mapping.synthetic_source_fallback_to_stored_source.cutoff_date_restricted_override"; | |||
| private static final Logger LOGGER = LogManager.getLogger(SyntheticSourceLicenseService.class); | |||
| static final long DEFAULT_CUTOFF_DATE = LocalDateTime.of(2024, 12, 12, 0, 0).toInstant(ZoneOffset.UTC).toEpochMilli(); | |||
| static final long DEFAULT_CUTOFF_DATE = LocalDateTime.of(2025, 1, 31, 0, 0).toInstant(ZoneOffset.UTC).toEpochMilli(); | |||
There was a problem hiding this comment.
I didn't check if there are any ITs that test "future" dates that aren't future anymore but lets update those if there are any 👍
kkrik-es
approved these changes
Nov 28, 2024
|
@elasticmachine run elasticsearch-ci/part-2 |
|
@elasticmachine update branch |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Nov 28, 2024
Update default cutoff date from 12-12-2024T00:00 UTC to 01-02-2025T00:00 UTC.
This was referenced Nov 28, 2024
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Nov 28, 2024
Update default cutoff date from 12-12-2024T00:00 UTC to 01-02-2025T00:00 UTC.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 28, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 28, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Update default cutoff date from 12-12-2024T00:00 UTC to 01-02-2025T00:00 UTC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update default cutoff date from 12-12-2024T00:00 UTC to 01-02-2025T00:00 UTC.
(note format is: dd-MM-yyyyThh:mm)