Support wildcards for getting repositories and snapshots #15151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>enhancement
:Distributed Coordination/Snapshot/Restore
|
Wondering if it requires some documentation changes? |
|
you're right, I'll add some docs. |
|
@dadoonet I've added documentation. Could you review this PR? |
| @@ -94,7 +94,8 @@ public void testRepositoryCreation() throws Exception { | |||
| assertThat(repositoriesMetaData.repository("test-repo-2").type(), equalTo("fs")); | |||
|
|
|||
| logger.info("--> check that both repositories can be retrieved by getRepositories query"); | |||
| GetRepositoriesResponse repositoriesResponse = client.admin().cluster().prepareGetRepositories().get(); | |||
There was a problem hiding this comment.
Can we still test prepareGetRepositories() without any parameter? Unless we test it somewhere else?
There was a problem hiding this comment.
no parameter is tested in other places
|
Left a very small comment about test. It looks good to me. I'd prefer that @bleskes double checks though. |
|
LGTM |
ywelsch
force-pushed
the
feature/get-snapshot-wildcards
branch
from
5bb9006 to
db5594a
Compare
ywelsch
pushed a commit
that referenced
this pull request
Dec 11, 2015
Support wildcards for getting repositories and snapshots
ywelsch
pushed a commit
that referenced
this pull request
Dec 11, 2015
brwe
added a commit
to brwe/elasticsearch
that referenced
this pull request
Dec 15, 2015
This was only introduced in 2.2 with elastic#15151 so we must not use wildcards when running with 2.0 nodes.
pull bot
pushed a commit
to rogues-gallery/elasticsearch
that referenced
this pull request
Jun 19, 2019
This commit adds multiple repositories support to get snapshots request. If some repository throws an exception this method does not fail fast instead, it returns results for all repositories. This PR is opened in favour of elastic#41799, because we decided to change the response format in a non-BwC manner. It makes sense to read a discussion of the aforementioned PR. This is the continuation of work done here elastic#15151.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports the following:
What is not supported:
Relates to #4758