Put mapping operations must update metadata of all types.

[jpountz]

Today put mapping operations only update metadata of the type that is being
modified, which is not enough since some modifications may have side-effects
on other types.

Closes #16239

[jpountz]

@rjernst could you give it a look?

[rjernst]

Is this else really necessary anymore? Looks like just some logging?

[jpountz]

It is logging only indeed. But whether or not to log things tends to be a bit controversial so I'd rather do it in another change if we want to remove it

[rjernst]

Sure, it was just an observation. :)

[rjernst]

LGTM

[rjernst]

@jpountz This is a pretty bad bug for mapping validation, and the fix is relatively simple. Should we put it into 2.2.1?

[s1monw]

+1 to 2.2.1 and also port it to 2.1 in case we do a bugfix release there too?

[jpountz]

The problem is that 2.2 has another bug: when you update a mapping with update_all_types=true, it will not refresh the mapping source of other types (we had this bug since 2.0 and it was fixed as a side-effect of #15539) so this fix alone won't help, we would also need to fix mapping updates to refresh the source of all types. If the consensus is that we should do it, I will do it, but these are big changes so I'm not comfortable pushing them to a bugfix release.

[travisjeffery]

Is there a workaround for 2.2? This bug is a really bad bug to leave like it is.

[rjernst]

@travisjeffery the workaround would be to explicitly send updates to every type that contains the field you are changing.

[clintongormley]

@rjernst @travisjeffery there is no way to do that. The update-mapping API only works on a single type at a time. The only time you can set the mapping for multiple types is at index creation.

[rjernst]

@clintongormley It does work. Updating them in one internal method call doesn't matter. We just need to get the mappings in memory back into the correct state.

DELETE test_index

PUT test_index
{
  "mappings": {
    "type1": {
      "properties": {
        "field": {
          "type": "string"
        }
      }
    },
    "type2": {
      "properties": {
        "field": {
          "type": "string"
        }
      }
    }
  }
}

PUT test_index/type1/_mapping?update_all_types=true
{
  "properties": {
    "field": {
      "type": "string",
      "search_analyzer": "keyword",
      "analyzer": "default"
    }
  }
}

GET test_index/_mapping?pretty
{
  "test_index" : {
    "mappings" : {
      "type1" : {
        "properties" : {
          "field" : {
            "type" : "string",
            "analyzer" : "default",
            "search_analyzer" : "keyword"
          }
        }
      },
      "type2" : {
        "properties" : {
          "field" : {
            "type" : "string"
          }
        }
      }
    }
  }
}

PUT test_index/type2/_mapping?update_all_types=true
{
  "properties": {
    "field": {
      "type": "string",
      "search_analyzer": "keyword",
      "analyzer": "default"
    }
  }
}

GET test_index/_mapping?pretty
{
  "test_index" : {
    "mappings" : {
      "type1" : {
        "properties" : {
          "field" : {
            "type" : "string",
            "analyzer" : "default",
            "search_analyzer" : "keyword"
          }
        }
      },
      "type2" : {
        "properties" : {
          "field" : {
            "type" : "string",
            "analyzer" : "default",
            "search_analyzer" : "keyword"
          }
        }
      }
    }
  }
}

[clintongormley]

Ah I see what you mean: using multiple calls to update mapping, ok

[fengzhi]

es 5.2 , I have many types. How can I add my new field to each type . I tryed put mapping with update_all_types but it does not actually update all types.