Replace FieldStatsProvider with a method on MappedFieldType. #17334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| randomBoolean(), randomBoolean(), null, null)); | ||
| } | ||
|
|
||
| public void testIsFieldWithinQuery() throws IOException { |
There was a problem hiding this comment.
Should we add a test to each of the other types to check that for random query bounds MappedFieldType.isFieldWithinQuery(IndexReader, Object, Object, boolean, boolean, TimeZone, DateMathParser) always returns Relation.INTERSECTS?
|
@jpountz I left some comments on the tests but I like how much this change simplifies the logic |
|
@colings86 I pushed more commits to improve the testing. Would you mind having another look? |
|
@jpountz Thanks for making the changes to the tests. LGTM |
…17334 FieldStatsProvider had to perform instanceof calls to properly handle dates or ip addresses. By moving the logic to MappedFieldType, each field type can check whether all values are within bounds its way. Note that this commit only keeps rewriting support for dates, which are the only field for which the rewriting mechanism is likely to help (because of time-based indices).
jpountz
force-pushed
the
enhancement/remove_fieldstats_provider
branch
from
08b6962 to
4c4bbb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldStatsProvider had to perform instanceof calls to properly handle dates or
ip addresses. By moving the logic to MappedFieldType, each field type can check
whether all values are within bounds its way.
Note that this commit only keeps rewriting support for dates, which are the only
field for which the rewriting mechanism is likely to help (because of time-based
indices).