Add date_index_name processor #17973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>feature
review
:Data Management/Ingest Node
| import java.util.Map; | ||
| import java.util.function.Function; | ||
|
|
||
| public final class DateIndexNameProcessor extends AbstractProcessor { |
There was a problem hiding this comment.
There is overlap with what the date and this processor do. This processor needs to parse the date before it can be printed into the index name with the desired format. So there is some code duplication, but I think that is ok. An alternative would be to come up with a common base class that then the date and this processor extend from, but I wasn't too fund of the idea either.
| |====== | ||
| | Name | Required | Default | Description | ||
| | `field` | yes | - | The field to get the date or timestamp from. | ||
| | `index_name_prefix` | yes | - | A prefix of the index name to be prepended before the printed date. |
There was a problem hiding this comment.
what if a user wants the index name to only be the date value?
There was a problem hiding this comment.
good point. I can make that option to be not required.
martijnvg
force-pushed
the
ingest_date_index_name_processor
branch
from
b585c01
to
385b84f
Compare
|
@talevy I made |
|
LGTM |
martijnvg
force-pushed
the
ingest_date_index_name_processor
branch
from
385b84f
to
b25ae4e
Compare
martijnvg
force-pushed
the
ingest_date_index_name_processor
branch
from
b25ae4e
to
7aca138
Compare
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 15, 2016
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The processor added in this PR dynamically redirects a document to an index based on a provided index name prefix, a date or timestamp field in the document being processed and the provided date rounding.
PR for #17814