Expose half-floats. #18887
Merged
Expose half-floats. #18887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
>feature
:Search Foundations/Mapping
| When possible, it is often more efficient to store floating-point data into an | ||
| integer using a scaling factor. For instance, it is more efficient to store | ||
| percentages as integers between 0 and 100 than as floating-point numbers between 0 | ||
| and 1. Another example would be prices: it will be bore efficient to store prices |
|
LGTM |
|
Thanks @rjernst! |
They have been implemented in https://issues.apache.org/jira/browse/LUCENE-7289. Ranges are implemented so that the accuracy loss only occurs at index time, which means that if you are searching for values between A and B, the query will match exactly all documents whose value rounded to the closest half-float point is between A and B.
jpountz
force-pushed
the
feature/half_floats
branch
from
e87fbb7 to
9ffb2ff
Compare
|
|
|
I did some unscientific benchmarking in order to make sure that half floats do not make things too slow. Query times are the same with floats and half floats, which makes sense since queries operate directly on the encoded representation anyway. However, a sum aggregation on the whole dataset runs about 8% slower with half floats due to the fact that half float bits are converted to doubles using software ( |
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Jul 22, 2016
Elasticsearch added a couple of new numeric datatypes, which means we need to update our type casting list to include them. Kibana should see them as "numbers" so they work properly in searches and aggs. Fixes elastic#7782 Related elastic/elasticsearch#18887 Related elastic/elasticsearch#19264
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Elasticsearch added a couple of new numeric datatypes, which means we need to update our type casting list to include them. Kibana should see them as "numbers" so they work properly in searches and aggs. Fixes elastic#7782 Related elastic/elasticsearch#18887 Related elastic/elasticsearch#19264 Former-commit-id: 298ee35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They have been implemented in https://issues.apache.org/jira/browse/LUCENE-7289.
Ranges are implemented so that the accuracy loss only occurs at index time,
which means that if you are searching for values between A and B, the query will
match exactly all documents whose value rounded to the closest half-float point
is between A and B.