Ensure PutMappingRequest.buildFromSimplifiedDef input are pairs #19837
Conversation
cbuescher
added
>enhancement
review
:Core/Infra/Transport API
|
LGTM. Thanks @cbuescher! |
…t pairs The method requires pairs of fieldnames and property arguments and will fail if the varargs input is an uneven number. We should check this and fail with an appropriate IllegalArgumentException instead.
cbuescher
force-pushed
the
inputValidation-PutMappingRequest
branch
from
304a703
to
e57f76a
Compare
|
It looks like documentation for 6.1 is not up to date : https://www.elastic.co/guide/en/elasticsearch/client/java-api/current/java-admin-indices.html How should we build a PutMappingRequest from json source as String now? |
|
@sfalquier thanks for the note, I think you are right about the docs needing an update, can you create a separate issue please and include a short description of you what you think is missing? The setSource(String source) method has been deprecated in #22691 (version 5.3) in favour of #setSource(String, XContentType). So with a json source you would probably want to use |
|
Thanks! |
The method expects pairs of fieldnames and property arguments and will fail if the varargs input is an uneven number. We should check this and fail with an appropriate IllegalArgumentException instead.
Relates to #19836