-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only use PUT
for index creation, not POST.
#20001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
>enhancement
>breaking
:Data Management/Indices APIs
APIs to create and manage indices and templates
v5.0.0-beta1
labels
Aug 16, 2016
-------------------------------------------------- | ||
// CONSOLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Left a question about the docs change, otherwise LGTM. |
All reservations resolved, LGTM. Thanks for converting those docs to |
LGTM |
…` or `position_increment_gap` set. elastic#20002 Closes elastic#19974
Currently both `PUT` and `POST` can be used to create indices. This commit removes support for `POST index_name` so that we can use it to index documents with auto-generated ids once types are removed. Relates elastic#15613
jpountz
force-pushed
the
fix/index_creation_put
branch
from
August 17, 2016 08:16
d2e03d3
to
d894db1
Compare
jpountz
added
:Core/Infra/REST API
REST infrastructure and utilities
and removed
:Data Management/Indices APIs
APIs to create and manage indices and templates
labels
Aug 18, 2016
tylersmalley
pushed a commit
to elastic/kibana
that referenced
this pull request
Aug 19, 2016
Resolves issue with Elasticsearch breaking change introduced in elastic/elasticsearch#20001 Fixes #8028 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Resolves issue with Elasticsearch breaking change introduced in elastic/elasticsearch#20001 Fixes elastic#8028 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Former-commit-id: dad5195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently both
PUT
andPOST
can be used to create indices. This commitremoves support for
POST index_name
so that we can use it to index documentswith auto-generated ids once types are removed.
Relates #15613
Relates #18160