Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use PUT for index creation, not POST. #20001

Merged
merged 2 commits into from
Aug 17, 2016

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Aug 16, 2016

Currently both PUT and POST can be used to create indices. This commit
removes support for POST index_name so that we can use it to index documents
with auto-generated ids once types are removed.

Relates #15613
Relates #18160

@jpountz jpountz added >enhancement >breaking :Data Management/Indices APIs APIs to create and manage indices and templates v5.0.0-beta1 labels Aug 16, 2016
--------------------------------------------------
// CONSOLE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@nik9000
Copy link
Member

nik9000 commented Aug 16, 2016

Left a question about the docs change, otherwise LGTM.

@nik9000
Copy link
Member

nik9000 commented Aug 16, 2016

All reservations resolved, LGTM. Thanks for converting those docs to // CONSOLE

@clintongormley
Copy link
Contributor

LGTM

Currently both `PUT` and `POST` can be used to create indices. This commit
removes support for `POST index_name` so that we can use it to index documents
with auto-generated ids once types are removed.

Relates elastic#15613
@jpountz jpountz force-pushed the fix/index_creation_put branch from d2e03d3 to d894db1 Compare August 17, 2016 08:16
@jpountz jpountz merged commit d894db1 into elastic:master Aug 17, 2016
@jpountz jpountz deleted the fix/index_creation_put branch August 17, 2016 08:20
@jpountz jpountz added :Core/Infra/REST API REST infrastructure and utilities and removed :Data Management/Indices APIs APIs to create and manage indices and templates labels Aug 18, 2016
tylersmalley pushed a commit to elastic/kibana that referenced this pull request Aug 19, 2016
Resolves issue with Elasticsearch breaking change introduced in elastic/elasticsearch#20001

Fixes #8028

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
Resolves issue with Elasticsearch breaking change introduced in elastic/elasticsearch#20001

Fixes elastic#8028

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Former-commit-id: dad5195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants