-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove groovy scripting language #21607
Conversation
Groovy was deprecated in 5.0. This change removes it, along with the legacy default language infrastructure in scripting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. As a follow-up, maybe we should add a note to the 5.x percolator docs to tell users that percolator queries should use painless or expressions, or the index storing those queries won't load in 6.0.
@@ -45,7 +45,7 @@ | |||
}, | |||
"lang": { | |||
"type": "string", | |||
"description": "The script language (default: groovy)" | |||
"description": "The script language (default: painless)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this part should be backported to 5.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed 60f70bc to 5.x
@rjernst This can not be checked in fast enough, are you busy or something :)? |
The method is not needed anymore, was needed only when we supported setting a legacy default lang, which was removed with elastic#21607 Relates to elastic#21607
Groovy was deprecated in 5.0. This change removes it, along with the
legacy default language infrastructure in scripting.