Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove groovy scripting language #21607

Merged
merged 3 commits into from
Nov 23, 2016
Merged

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Nov 17, 2016

Groovy was deprecated in 5.0. This change removes it, along with the
legacy default language infrastructure in scripting.

Groovy was deprecated in 5.0. This change removes it, along with the
legacy default language infrastructure in scripting.
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. As a follow-up, maybe we should add a note to the 5.x percolator docs to tell users that percolator queries should use painless or expressions, or the index storing those queries won't load in 6.0.

@@ -45,7 +45,7 @@
},
"lang": {
"type": "string",
"description": "The script language (default: groovy)"
"description": "The script language (default: painless)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this part should be backported to 5.x

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed 60f70bc to 5.x

@clintongormley clintongormley added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Nov 19, 2016
@clintongormley clintongormley changed the title Scripting: Remove groovy scripting language Remove groovy scripting language Nov 19, 2016
@jdconrad
Copy link
Contributor

@rjernst This can not be checked in fast enough, are you busy or something :)?

@rjernst rjernst merged commit 6940b2b into elastic:master Nov 23, 2016
@rjernst rjernst deleted the groovy_goes_boom branch November 23, 2016 07:18
javanna added a commit to javanna/elasticsearch that referenced this pull request Feb 8, 2017
The method is not needed anymore, was needed only when we supported setting a legacy default lang, which was removed with elastic#21607

Relates to elastic#21607
javanna added a commit that referenced this pull request Feb 9, 2017
The method is not needed anymore, was needed only when we supported setting a legacy default lang, which was removed with #21607

Relates to #21607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v6.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants