Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BulkProcessor methods with XContentType parameter #23078

Merged
merged 3 commits into from
Feb 10, 2017

Conversation

jaymode
Copy link
Member

@jaymode jaymode commented Feb 9, 2017

This commit adds methods to the BulkProcessor that accept bytes and a XContentType to avoid content type detection. The
methods that do not accept XContentType with bytes have been deprecated by this commit.

Relates #22691

This commit adds methods to the BulkProcessor that accept bytes and a XContentType to avoid content type detection. The
methods that do not accept XContentType with bytes have been deprecated by this commit.

Relates elastic#22691
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shall we maybe have some test call these new methods?

@jaymode
Copy link
Member Author

jaymode commented Feb 10, 2017

shall we maybe have some test call these new methods?

I updated one of the tests to use this method randomly

@javanna
Copy link
Member

javanna commented Feb 10, 2017

thanks @jaymode looks great. still LGTM

@jaymode jaymode merged commit 7018b6a into elastic:master Feb 10, 2017
jaymode added a commit that referenced this pull request Feb 10, 2017
This commit adds methods to the BulkProcessor that accept bytes and a XContentType to avoid content type detection. The
methods that do not accept XContentType with bytes have been deprecated by this commit.

Relates #22691
jaymode added a commit that referenced this pull request Feb 10, 2017
This commit adds methods to the BulkProcessor that accept bytes and a XContentType to avoid content type detection. The
methods that do not accept XContentType with bytes have been deprecated by this commit.

Relates #22691
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 10, 2017
* master:
  Fix alias HEAD requests
  Upgrade to lucene-6.5.0-snapshot-f919485. (elastic#23087)
  Add BulkProcessor methods with XContentType parameter (elastic#23078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants