Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait no initializing shards #26578

Closed

Conversation

matarrese
Copy link
Contributor

Hello, I don't know if @Hogusong is still working on this issue, so I decided to bring it up and send you a pull request. It is not intended to be ready to be tested, as it is failing some tests. I am just asking if it's possible to have a review and understand if it goes in the right direction. If other people working on this, please feel free to close it.
Closes #25623

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ywelsch ywelsch self-requested a review September 20, 2017 09:37
@ywelsch
Copy link
Contributor

ywelsch commented Sep 20, 2017

Sure, this looks good so far. It still needs adaptions on the REST layer, tests and all that.

@@ -221,6 +224,10 @@ private boolean prepareResponse(final ClusterHealthRequest request, final Cluste
if (request.waitForNoRelocatingShards() && response.getRelocatingShards() == 0) {
waitForCounter++;
}
if (request.waitForNoInitializingShards() && !clusterState.getRoutingNodes().hasInactivePrimaries() &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use the same approach as for the waitForNoRelocatingShards a few lines above, i.e. request.waitForNoInitializingShards() && response.getInitializingShards() == 0

@ywelsch
Copy link
Contributor

ywelsch commented Nov 13, 2017

@matarrese any updates on this? I'll close the PR due to inactivity. Please let us know if you still want to work on this.

@ywelsch ywelsch closed this Nov 13, 2017
@matarrese
Copy link
Contributor Author

Hi @ywelsch , happy to go back working on this. Is it possible to open the pull request?

@jasontedor
Copy link
Member

This was addressed in #27489.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a wait for no intializing shards parameter to cluster health
4 participants