Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of Gateway*** classes #26706

Merged
merged 5 commits into from
Sep 20, 2017
Merged

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Sep 19, 2017

  • Removes mutual dependency between GatewayMetaState and TransportNodesListGatewayMetaState
  • Deguices MetaDataIndexUpgradeService
  • Deguices GatewayMetaState
  • Makes Gateway the master-level component that is only responsible for coordinating the state recovery

Previously this exception would be thrown as part of a big Guice creation error. Guice exposes the messages of all sub-exceptions in one big chunk.
We now have to be more selective.
@ywelsch ywelsch merged commit 5f40706 into elastic:master Sep 20, 2017
@ywelsch
Copy link
Contributor Author

ywelsch commented Sep 20, 2017

Thanks @bleskes

ywelsch added a commit that referenced this pull request Sep 20, 2017
- Removes mutual dependency between GatewayMetaState and TransportNodesListGatewayMetaState
- Deguices MetaDataIndexUpgradeService
- Deguices GatewayMetaState
- Makes Gateway the master-level component that is only responsible for coordinating the state recovery
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Sep 20, 2017
* master:
  [DOCS] Added index-shared4 and index-shared5.asciidoc
  BulkProcessor flush runnable preserves the thread context from creation time (elastic#26718)
  Catch exceptions and inform handler in RemoteClusterConnection#collectNodes (elastic#26725)
  [Docs] Fix name of character filter in example. (elastic#26724)
  Remove parse field deprecations in query builders (elastic#26711)
  elastic#26720: Set the correct bwc version after backport to 6.0
  Remove deprecated type and slop field in MatchQueryBuilder (elastic#26720)
  Refactoring of Gateway*** classes (elastic#26706)
  Make RestHighLevelClient's Request class public (elastic#26627)
  Deguice ActionFilter (elastic#26691)
  aggs: Allow aggregation sorting via nested aggregation.
  Build: Set bwc builds to always set snapshot (elastic#26704)
  File Discovery: Remove fallback with zen discovery (elastic#26667)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants