Remove unused parameters for AnalysisRegistry#processAnalyzerFactory #27232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
liketic
commented
Nov 2, 2017
| @@ -188,9 +183,9 @@ public IndexAnalyzers build(IndexSettings indexSettings) throws IOException { | |||
| } | |||
|
|
|||
| public Map<String, AnalyzerProvider<?>> buildNormalizerFactories(IndexSettings indexSettings) throws IOException { | |||
| final Map<String, Settings> noralizersSettings = indexSettings.getSettings().getGroups("index.analysis.normalizer"); | |||
| final Map<String, Settings> normalizersSettings = indexSettings.getSettings().getGroups("index.analysis.normalizer"); | |||
liketic
commented
Nov 2, 2017
| @@ -510,11 +491,9 @@ public IndexAnalyzers build(IndexSettings indexSettings, | |||
| unmodifiableMap(analyzers), unmodifiableMap(normalizers)); | |||
| } | |||
|
|
|||
| private void processAnalyzerFactory(DeprecationLogger deprecationLogger, | |||
| IndexSettings indexSettings, | |||
| private void processAnalyzerFactory(IndexSettings indexSettings, | |||
There was a problem hiding this comment.
Remove unused deprecationLogger and indexSettings and analyzerAliases .
liketic
commented
Nov 2, 2017
| tokenizerFactoryFactories.get("keyword"), tokenFilterFactoryFactories, charFilterFactoryFactories); | ||
| } | ||
| for (Map.Entry<String, NamedAnalyzer> entry : analyzerAliases.entrySet()) { |
There was a problem hiding this comment.
analyzerAliases is never updated.
|
@liketic CI doesn't seem happy, although the error doesn't seem to be related to your changes, could you either rebase your branch or merge in master before I kick off another build? |
…and AnalysisRegistry#processNormalizerFactory
liketic
force-pushed
the
remove-unused-parameters
branch
from
275246e to
b5e8c4e
Compare
|
@cbuescher Rebase done. Please try again. |
|
@elasticmachine test this please |
cbuescher
reviewed
Nov 6, 2017
jasontedor
added a commit
that referenced
this pull request
Nov 7, 2017
* master: (25 commits) Disable bwc tests in preparation of backporting #26931 TemplateUpgradeService should only run on the master (#27294) Die with dignity while merging Fix profiling naming issues (#27133) Correctly encode warning headers Fixed references to Multi Index Syntax (#27283) Add an active Elasticsearch WordPress plugin link (#27279) Setting url parts as required to reflect the code base (#27263) keys in aggs percentiles need to be in quotes. (#26905) Align routing param type with search.json (#26958) Update to support bulk updates by query (#27172) Remove duplicated SnapshotStatus (#27276) add split index reference in indices.asciidoc Add ability to split shards (#26931) [Docs] Fix minor paragraph indentation error for multiple Indices params (#25535) Upgrade to Jackson 2.8.10 (#27230) Fix inconsistencies in the rest api specs for `tasks` (#27163) Adjust RestHighLevelClient method modifiers (#27238) Remove unused parameters in AnalysisRegistry (#27232) Add more information on `_failed_to_convert_` exception (#27034) ...
jasontedor
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Nov 7, 2017
* ccr: (127 commits) Disable bwc tests in preparation of backporting elastic#26931 TemplateUpgradeService should only run on the master (elastic#27294) Die with dignity while merging Fix profiling naming issues (elastic#27133) Correctly encode warning headers Fixed references to Multi Index Syntax (elastic#27283) Add an active Elasticsearch WordPress plugin link (elastic#27279) Setting url parts as required to reflect the code base (elastic#27263) keys in aggs percentiles need to be in quotes. (elastic#26905) Align routing param type with search.json (elastic#26958) Update to support bulk updates by query (elastic#27172) Remove duplicated SnapshotStatus (elastic#27276) add split index reference in indices.asciidoc Add ability to split shards (elastic#26931) [Docs] Fix minor paragraph indentation error for multiple Indices params (elastic#25535) Upgrade to Jackson 2.8.10 (elastic#27230) Fix inconsistencies in the rest api specs for `tasks` (elastic#27163) Adjust RestHighLevelClient method modifiers (elastic#27238) Remove unused parameters in AnalysisRegistry (elastic#27232) Add more information on `_failed_to_convert_` exception (elastic#27034) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused parameters for
AnalysisRegistry#processAnalyzerFactoryandAnalysisRegistry#processNormalizerFactory. Any comments are appreciated. 👍