-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elasticsearch-nio jar for base nio classes #27801
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
88444a6
WIP
Tim-Brooks a82314a
WIP
Tim-Brooks 31cdc9e
WIP
Tim-Brooks 1f9d794
A few cleanups
Tim-Brooks 075d81c
Don't currently need socket permissions for elasticsearch-nio
Tim-Brooks 00e19ba
Merge remote-tracking branch 'upstream/master' into work_on_base_nio
Tim-Brooks b48f467
Merge nio group
Tim-Brooks 0afab48
Cleanups
Tim-Brooks 7a30220
Merge remote-tracking branch 'upstream/master' into work_on_base_nio
Tim-Brooks dcce8fb
Merge remote-tracking branch 'upstream/master' into work_on_base_nio
Tim-Brooks 71ddafa
Remove comment
Tim-Brooks 58f6e40
Changes based on review
Tim-Brooks adda661
Fix permissions
Tim-Brooks 4a4ee20
Drop group assignment
Tim-Brooks 5d1800a
Add todo comment
Tim-Brooks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
/* | ||
* Licensed to Elasticsearch under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import org.elasticsearch.gradle.precommit.PrecommitTasks | ||
|
||
apply plugin: 'elasticsearch.build' | ||
apply plugin: 'nebula.maven-base-publish' | ||
apply plugin: 'nebula.maven-scm' | ||
|
||
archivesBaseName = 'elasticsearch-nio' | ||
|
||
publishing { | ||
publications { | ||
nebula { | ||
artifactId = archivesBaseName | ||
} | ||
} | ||
} | ||
|
||
dependencies { | ||
compile "org.apache.logging.log4j:log4j-api:${versions.log4j}" | ||
|
||
testCompile "com.carrotsearch.randomizedtesting:randomizedtesting-runner:${versions.randomizedrunner}" | ||
testCompile "junit:junit:${versions.junit}" | ||
testCompile "org.hamcrest:hamcrest-all:${versions.hamcrest}" | ||
testCompile("org.elasticsearch.test:framework:${version}") { | ||
exclude group: 'org.elasticsearch', module: 'elasticsearch-nio' | ||
} | ||
} | ||
|
||
forbiddenApisMain { | ||
// elasticsearch-nio does not depend on core, so only jdk signatures should be checked | ||
// es-all is not checked as we connect and accept sockets | ||
signaturesURLs = [PrecommitTasks.getResource('/forbidden/jdk-signatures.txt')] | ||
} | ||
|
||
//JarHell is part of es core, which we don't want to pull in | ||
jarHell.enabled=false | ||
|
||
thirdPartyAudit.excludes = [ | ||
'org/osgi/framework/AdaptPermission', | ||
'org/osgi/framework/AdminPermission', | ||
'org/osgi/framework/Bundle', | ||
'org/osgi/framework/BundleActivator', | ||
'org/osgi/framework/BundleContext', | ||
'org/osgi/framework/BundleEvent', | ||
'org/osgi/framework/SynchronousBundleListener', | ||
'org/osgi/framework/wiring/BundleWire', | ||
'org/osgi/framework/wiring/BundleWiring' | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
7a2999229464e7a324aa503c0a52ec0f05efe7bd |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will open a separate issue for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #27933.