Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration docs for Geoip Processor #29006

Merged

Conversation

danielmitterdorfer
Copy link
Member

This commit adds a note to the 6.3 docs that Geoip database files are
now stored uncompressed.

Relates #28963

This commit adds a note to the 6.3 docs that Geoip database files are
now stored uncompressed.

Relates elastic#28963
@danielmitterdorfer danielmitterdorfer added >docs General docs changes :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v6.3.0 labels Mar 13, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion to accept or reject. LGTM.


==== Ingest Geoip Plugin

* In earlier versions, database files have been stored as gzip compressed files with the extension `.gz`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a line about why we did this? Always better to understand why one needs to change his ways.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an explanation for the original behavior and also why we did the change.

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmitterdorfer danielmitterdorfer merged commit 540f705 into elastic:6.x Mar 13, 2018
@jasontedor
Copy link
Member

Thanks @danielmitterdorfer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes v6.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants