Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy mapping code. #29224

Merged
merged 7 commits into from
Apr 11, 2018
Merged

Remove legacy mapping code. #29224

merged 7 commits into from
Apr 11, 2018

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Mar 23, 2018

Some features have been deprecated since 6.0 like the _parent field or the
ability to have multiple types per index. This allows to remove quite some
code, which in-turn will hopefully make it easier to proceed with the removal
of types.

@jpountz
Remove legacy mapping code.
910d1aa 
Some features have been deprecated since `6.0` like the `_parent` field or the
ability to have multiple types per index. This allows to remove quite some
code, which in-turn will hopefully make it easier to proceed with the removal
of types.
@jpountz jpountz added >enhancement >breaking v7.0.0 :Search Foundations/Mapping Index mappings, including merging and defining field types labels Mar 23, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

jimczi
jimczi approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's huge, I am glad to see all this BWC code going away.
LGTM, thanks a lot foir doing that @jpountz !

@jpountz jpountz merged commit 4918924 into elastic:master Apr 11, 2018
@jpountz
Copy link
Contributor Author

jpountz commented Apr 11, 2018

Thanks @jimczi

@jpountz jpountz deleted the remove/legacy_mapping_code branch April 11, 2018 07:41
@LeeDr LeeDr mentioned this pull request Apr 13, 2018
Closed
@mP1 mP1 mentioned this pull request Apr 16, 2018
Closed
@clintongormley clintongormley mentioned this pull request Apr 18, 2018
Closed
@dnhatn dnhatn mentioned this pull request Dec 15, 2018
Merged
dnhatn added a commit that referenced this pull request Dec 19, 2018
@dnhatn
Fix translog bwc serialization (#36676)
b63f9b9 
Serializing of a Translog#Index from v7.0.0 to 6.x is broken since
#29224 where we removed the _parent field.

Relates #29224
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Jun 21, 2019
@russcam
Remove parent param from obsoletes
795394b 
Relates: elastic/elasticsearch#29224
@russcam russcam mentioned this pull request Jun 21, 2019
Merged
Mpdreamz pushed a commit to elastic/elasticsearch-net that referenced this pull request Jun 21, 2019
@russcam @Mpdreamz
Remove parent param from obsoletes (#3848)
42803e0 
Relates: elastic/elasticsearch#29224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimczi jimczi jimczi approved these changes

Assignees
No one assigned
Labels
>breaking >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpountz @elasticmachine @jimczi @colings86