Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to migration docs on silent batch mode #29365

Merged
merged 4 commits into from
Apr 5, 2018

Conversation

jasontedor
Copy link
Member

@jasontedor jasontedor commented Apr 4, 2018

A previous change removed silent batch mode for the plugin installer. This commit adds a note to the migration docs regarding this change.

Relates #29359

A previous change removed silent batch mode for the plugin
installer. This commit adds a note to the migration docs regarding this
change.
@jasontedor jasontedor added >docs General docs changes review :Core/Infra/Plugins Plugin API and infrastructure v6.3.0 labels Apr 4, 2018
@jasontedor jasontedor requested a review from dolaru April 4, 2018 11:13
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@spinscale spinscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not a hundred percent sure about having a snippet like foo bar starting in one line and ending in the other, but I think that works (using deprecated[] does not IIRC)

Copy link
Member

@dolaru dolaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* 6.x:
  Move testMappingConflictRootCause to different class
  Enhance error for out of bounds byte size settings (elastic#29338)
@jasontedor
Copy link
Member Author

Thanks for thinking of that @spinscale. I built the docs and they render fine as-is.

screen shot 2018-04-04 at 9 38 05 am

* 6.x:
  Improve similarity integration. (elastic#29187)
  Fix some query extraction bugs. (elastic#29283)
  Fixed quote_field_suffix in query_string (elastic#29332)
  TEST: Update negative byte size setting error msg
  Fix bwc in GeoDistanceQuery serialization (elastic#29325)
@jasontedor jasontedor merged commit 739f160 into elastic:6.x Apr 5, 2018
@jasontedor
Copy link
Member Author

Thanks @spinscale and @dolaru.

@jasontedor jasontedor deleted the silent-batch-mode-migration branch April 5, 2018 00:59
martijnvg added a commit that referenced this pull request Apr 5, 2018
* es/6.x: (68 commits)
  Add note to migration docs on silent batch mode (#29365)
  Allow using distance measure in the geo context precision (#29273)
  Disable failing query in QueryBuilderBWCIT.
  Improve similarity integration. (#29187)
  Fix some query extraction bugs. (#29283)
  Fixed quote_field_suffix in query_string (#29332)
  TEST: Update negative byte size setting error msg
  Fix bwc in GeoDistanceQuery serialization (#29325)
  Move testMappingConflictRootCause to different class
  Enhance error for out of bounds byte size settings (#29338)
  [Docs] Correct javadoc of GetIndexRequest (#29364)
  Check presence of multi-types before validating new mapping (#29316)
  Make TransportRankEvalAction members final
  Pass through script params in scripted metric agg (#29154)
  Remove silent batch mode from install plugin (#29359)
  Track Lucene operations in engine explicitly (#29357)
  Build: Fix Java9 MR build (#29312)
  Reindex: Fix error in delete-by-query rest spec (#29318)
  Move Nullable into core (#29341)
  [Docs] Correct experimental note formatting
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Plugins Plugin API and infrastructure >docs General docs changes v6.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants