Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting-started.asciidoc #29518

Merged
merged 2 commits into from
Aug 17, 2018
Merged

Update getting-started.asciidoc #29518

merged 2 commits into from
Aug 17, 2018

Conversation

markwalkom
Copy link
Contributor

Highlighted that you can change shard counts using _shrink and _split.

Highlighted that you can change shard counts using `_shrink` and `_split`.
@colings86 colings86 added >docs General docs changes :Data Management/Indices APIs APIs to create and manage indices and templates labels Apr 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to be more careful with the wording here. This changes makes it looks very convenient and easy to change the number of shards on an existing index and so I am worried that users will think that they no longer need to think about how many shards to use before they create the index. In actuality you still need to think about this because changing the shards is not a trivial action and requires that you have a node which has enough free space for 2x the size of thee complete index.

Made it clearer that split/shrink is not trivial and planning is ++
@javanna
Copy link
Member

javanna commented Aug 16, 2018

@colings86 are you ok with the latest commit?

Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javanna
Copy link
Member

javanna commented Aug 16, 2018

retest this please

@javanna javanna changed the base branch from 6.2 to 6.x August 16, 2018 18:29
@javanna javanna changed the base branch from 6.x to 6.2 August 16, 2018 18:29
@javanna javanna changed the base branch from 6.2 to 6.3 August 16, 2018 18:29
@javanna javanna changed the base branch from 6.3 to 6.2 August 16, 2018 18:30
@javanna
Copy link
Member

javanna commented Aug 17, 2018

The build failure is totally unrelated, I am going to merge this in.

@javanna javanna merged commit 36c83fb into 6.2 Aug 17, 2018
javanna pushed a commit that referenced this pull request Aug 17, 2018
Highlighted that you can change shard counts using `_shrink` and `_split`.
javanna pushed a commit that referenced this pull request Aug 17, 2018
Highlighted that you can change shard counts using `_shrink` and `_split`.
javanna pushed a commit that referenced this pull request Aug 17, 2018
Highlighted that you can change shard counts using `_shrink` and `_split`.
javanna pushed a commit that referenced this pull request Aug 17, 2018
Highlighted that you can change shard counts using `_shrink` and `_split`.
jasontedor added a commit that referenced this pull request Aug 18, 2018
* 6.x: (42 commits)
  [DOCS] Splits the users API documentation into multiple pages (#32825)
  [DOCS] Splits the token APIs into separate pages (#32865)
  [DOCS] Creates redirects for role management APIs page
  Bypassing failing test PainlessDomainSplitIT#testHRDSplit (#32966)
  TEST: Mute testRetentionPolicyChangeDuringRecovery
  [DOCS] Fixes more broken links to role management APIs
  [Docs] Tweaks and fixes to rollup docs
  [DOCS] Fixes links to role management APIs
  [ML][TEST] Fix BasicRenormalizationIT after adding multibucket feature
  [DOCS] Splits the roles API documentation into multiple pages (#32794)
  [TEST]  Run pre 6.4 nodes in non-FIPS JVMs (#32901)
  Remove assertion in testDocStats on deletedDocs counter (#32914)
  [ML] fix updating opened jobs scheduled events (#31651) (#32881)
  Enable FIPS140LicenseBootstrapCheck (#32903)
  HLRC: Move ML request converters into their own class (#32906)
  [DOCS] Update getting-started.asciidoc (#29518)
  Fix allowed value for HighlighterBuilder encoder in javadocs (#32780)
  [DOCS] Add "remove a tag" script logic as an example (#32556)
  RFC: Test that example plugins build stand-alone (#32235)
  Security: remove put privilege API (#32879)
  ...
@colings86 colings86 deleted the markw/docs-shrinksplit-index branch May 27, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >docs General docs changes v6.2.5 v6.3.3 v6.4.0 v6.5.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants