-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getting-started.asciidoc #29518
Conversation
Highlighted that you can change shard counts using `_shrink` and `_split`.
Pinging @elastic/es-core-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to be more careful with the wording here. This changes makes it looks very convenient and easy to change the number of shards on an existing index and so I am worried that users will think that they no longer need to think about how many shards to use before they create the index. In actuality you still need to think about this because changing the shards is not a trivial action and requires that you have a node which has enough free space for 2x the size of thee complete index.
Made it clearer that split/shrink is not trivial and planning is ++
@colings86 are you ok with the latest commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
retest this please |
The build failure is totally unrelated, I am going to merge this in. |
Highlighted that you can change shard counts using `_shrink` and `_split`.
Highlighted that you can change shard counts using `_shrink` and `_split`.
Highlighted that you can change shard counts using `_shrink` and `_split`.
Highlighted that you can change shard counts using `_shrink` and `_split`.
* 6.x: (42 commits) [DOCS] Splits the users API documentation into multiple pages (#32825) [DOCS] Splits the token APIs into separate pages (#32865) [DOCS] Creates redirects for role management APIs page Bypassing failing test PainlessDomainSplitIT#testHRDSplit (#32966) TEST: Mute testRetentionPolicyChangeDuringRecovery [DOCS] Fixes more broken links to role management APIs [Docs] Tweaks and fixes to rollup docs [DOCS] Fixes links to role management APIs [ML][TEST] Fix BasicRenormalizationIT after adding multibucket feature [DOCS] Splits the roles API documentation into multiple pages (#32794) [TEST] Run pre 6.4 nodes in non-FIPS JVMs (#32901) Remove assertion in testDocStats on deletedDocs counter (#32914) [ML] fix updating opened jobs scheduled events (#31651) (#32881) Enable FIPS140LicenseBootstrapCheck (#32903) HLRC: Move ML request converters into their own class (#32906) [DOCS] Update getting-started.asciidoc (#29518) Fix allowed value for HighlighterBuilder encoder in javadocs (#32780) [DOCS] Add "remove a tag" script logic as an example (#32556) RFC: Test that example plugins build stand-alone (#32235) Security: remove put privilege API (#32879) ...
Highlighted that you can change shard counts using
_shrink
and_split
.