Deprecate Empty Templates #30194
Merged
Deprecate Empty Templates #30194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates/scripts to be loaded on start up.
jdconrad
added
the
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra |
|
@martijnvg Hey Martijn, if you're back from holiday, would appreciate you having a look at this when you have a spare moment. Thanks! |
|
5.6.10 seems like a long way to backport this. If you plan from removing from master I think it is fine to release this with 6.4. |
nik9000
reviewed
May 7, 2018
| */ | ||
| private StoredScriptSource build() { | ||
| private StoredScriptSource build(boolean ignore) { |
|
I agree with @nik9000 comment about just getting this change in 6.x branch and master. |
|
@martijnvg @nik9000 Thanks for the reviews! Will push as soon as CI is completed. |
jdconrad
added a commit
that referenced
this pull request
May 16, 2018
Deprecate the use of empty templates. Bug fix allows empty templates/scripts to be loaded on start up for upgrades/restarts, but empty templates can no longer be created.
martijnvg
added a commit
that referenced
this pull request
May 17, 2018
* es/6.x: (44 commits) SQL: Remove dependency for server's version from JDBC driver (#30631) Make xpack modules instead of a meta plugin (#30589) Security: Remove SecurityLifecycleService (#30526) Build: Add task interdependencies for ssl configuration (#30633) Mute ShrinkIndexIT [ML] DeleteExpiredDataAction should use client with origin (#30646) Reindex: Fixed typo in assertion failure message (#30619) [DOCS] Fixes list of unconverted snippets in build.gradle Use readFully() to read bytes from CipherInputStream (#30640) Add Create Repository High Level REST API (#30501) [DOCS] Reorganizes RBAC documentation Test: increase search logging for LicensingTests Delay _uid field data deprecation warning (#30651) Deprecate Empty Templates (#30194) Remove unused DirectoryUtils class. (#30582) Mitigate date histogram slowdowns with non-fixed timezones. (#30534) [TEST] Remove AwaitsFix in IndicesOptionsTests#testSerialization S3 repo plugin populates SettingsFilter (#30652) Rest High Level client: Add List Tasks (#29546) Fixes IndiceOptionsTests to serialise correctly (#30644) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates empty templates. This will be followed up with another PR for just 7.0 that will remove the ability to add empty templates, and will drop empty templates during upgrades with a warning.
Also removes a backwards incompatible check for empty code strings being loaded from stored scripts. Search templates did not have an appropriate check for not allowing stored scripts to have an empty code string, so when an empty search template is added, future restarts of the node will fail.