-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for cluster API #30468
Merged
Merged
Update docs for cluster API #30468
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
165eaf8
Update docs for cluster API
PnPie 5b4c070
Update according to comments
PnPie 4344a88
small format change
PnPie 1ebb53e
still some changes
PnPie ff337e9
Merge branch 'master' into 2018-06-08-node-filter-docs
DaveCTurner 86c08f0
Some rewording, and add a note about filters in cluster stats
DaveCTurner 4a63d4a
Merge branch 'master' into update_cluster_api_docs
DaveCTurner e02ec75
Clarify that both attribute names and values can be patterns
DaveCTurner 19c6cb6
Merge branch 'master' into update_cluster_api_docs
DaveCTurner dc180f9
Fix regression introduced in merge
DaveCTurner 779e281
Fix regression introduced in merge
DaveCTurner c11a1ba
Merge branch 'master' into update_cluster_api_docs
DaveCTurner ae3b2ed
Spell out that wildcards are optional
DaveCTurner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this a little bit confusing. It suggests that name, address, or hostname will only be resolved when using wildcards. Maybe change the previous entry (a node id) to say
a node id, node name, address or hostname to add the node with the corresponding id, name, address or hostname to the set
to reinforce that exact matching also works.