QA: Check rollup job creation safety #31036
Conversation
Prior to elastic#30963 you could create a rollup job that would poison the cluster state for nodes that don't have xpack installed. This adds a test that would have caught that.
nik9000
added
>test
|
Pinging @elastic/es-search-aggs |
|
I targeted this at 6.x because master will never support a rolling upgrade that enables xpack and doesn't have the right rolling upgrade scenarios to properly test this. 6.x does. |
I'm confused. Why wouldn't we want to test going from an OSS 7.0 cluster to an x-pack 7.0.1 cluster? |
Right now we don't have any way to test that. Besides that we have to draw the line somewhere and the place I've been talking about drawing the line for a few weeks is "you don't upgrade and switch distributions at the same time except in the special case of pre-6.3-OSS to post-6.3-default". In addition "you don't go from pre-6.3-OSS to post-6.3-default with security enabled". I really want us to make a blog post where we say "here are all of the restart/upgrade scenarios that we test" so we can point people to it and say "if you do anything else it might not work". I'm going to merge this PR to 6.x and backport to 6.3 so we can get the extra coverage. If we decide that we do want to test the scenario @ywelsch talked about we'll have to do a fair bit of work to the master branch and forward porting this change will end up as part of it. |
Prior to #30963 you could create a rollup job that would poison the cluster state for nodes that don't have xpack installed. This adds a test that would have caught that.
* 6.x: Add TRACE, CONNECT, and PATCH http methods (#31079) Change ObjectParser exception (#31030) Make sure KeywordFieldMapper#clone preserves split_queries_on_whitespace. (#31049) [DOCS] Removes duplicated authentication pages [Rollup] Specialize validation exception for easier management (#30339) Enable customizing REST tests blacklist (#31074) [DOCS] Moves machine learning overview to stack-docs [ML] Add secondary sort to ML events (#31063) QA: Check rollup job creation safety (#31036) Adapt bwc versions after backporting #31045 to 6.3 Remove usage of explicit type in docs (#29667) Move pipeline APIs to ingest namespace (#31027) Adapt bwc versions after backporting #31045 to 6.x Make Persistent Tasks implementations version and feature aware (#31045) Mute MatchPhrase*QueryBuilderTests [Docs] Fix typo in watcher conditions documentation (#30989) Remove wrong link in index phrases doc Reuse expiration date of trial licenses (#31033) Index phrases (#30450) [DOCS] Fixes accounting setting names (#30863) [DOCS] Rewords _field_names documentation (#31029)
Prior to #30963 you could create a rollup job that would poison the
cluster state for nodes that don't have xpack installed. This adds a
test that would have caught that.