Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor typos in templates.asciidoc #31167

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Minor typos in templates.asciidoc #31167

merged 1 commit into from
Jun 7, 2018

Conversation

rafalbig
Copy link
Contributor

@rafalbig rafalbig commented Jun 7, 2018

Hi All,

I've corrected two minor typos:

  1. replaced fieldname with field name
  2. added a dot

Cheers,
Rafal

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@rafalbig
Minor typos in templates.asciidoc
837a764 
Hi All,

I've corrected two minor typos:
1. replaced `fieldname` with `field name`
2. added a dot

Cheers,
Rafal
cbuescher
cbuescher reviewed Jun 7, 2018
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbuescher cbuescher merged commit 314c2c1 into elastic:6.2 Jun 7, 2018
cbuescher pushed a commit that referenced this pull request Jun 7, 2018
@rafalbig
[Docs] Correct minor typos in templates.asciidoc (#31167)
f1256fa
cbuescher pushed a commit that referenced this pull request Jun 7, 2018
@rafalbig
[Docs] Correct minor typos in templates.asciidoc (#31167)
e838d66
cbuescher pushed a commit that referenced this pull request Jun 7, 2018
@rafalbig
[Docs] Correct minor typos in templates.asciidoc (#31167)
749d390
jasontedor added a commit that referenced this pull request Jun 8, 2018
@jasontedor
Merge remote-tracking branch 'elastic/6.x' into ccr-6.x
a095780 
* elastic/6.x: (50 commits)
  Painless: Restructure/Clean Up of Spec Documentation (#31013)
  Add support for ignore_unmapped to geo sort (#31153)
  Enable engine factory to be pluggable (#31183)
  Remove vestiges of animal sniffer (#31178)
  Rename elasticsearch-core to core (#31185)
  Move cli sub-project out of server to libs (#31184)
  QA: Fixup rolling restart tests
  QA: Better seed nodes for rolling restart
  [DOCS] Fixes broken link in release notes
  [DOCS] Fixes broken link in auditing settings
  [DOCS] Moves ML content to stack-docs
  [DOCS] Clarifies recommendation for audit index output type (#31146)
  QA: Set better node names on rolling restart tests
  QA: Skip mysterious failing rolling upgrade tests
  Share common parser in some AcknowledgedResponses (#31169)
  Fix random failure on SearchQueryIT#testTermExpansionExceptionOnSpanFailure
  Remove reference to multiple fields with one name (#31127)
  Remove BlobContainer.move() method (#31100)
  [Docs] Correct minor typos in templates.asciidoc (#31167)
  Use ESBlobStoreRepositoryIntegTestCase to test the repository-s3 plugin (#29315)
  ...
@tomcallahan tomcallahan added the >docs General docs changes label Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher left review comments

Assignees
No one assigned
Labels
>docs General docs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafalbig @cbuescher @tomcallahan