Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify pipelining handlers to require full requests #31280

Merged
merged 2 commits into from
Jun 13, 2018
Merged

Modify pipelining handlers to require full requests #31280

merged 2 commits into from
Jun 13, 2018

Commits on Jun 12, 2018

  1. Modify pipeling handlers to require full requests 

    Currently the http pipelining handlers seem to support chunked http
content. However, this does not make sense. There is a content
aggregator in the pipeline before the pipelining handler. This means the
pipelining handler should only see full http messages. Additionally, the
request handler immediately after the pipelining handler only supports
full messages.

This commit modifies both nio and netty4 pipelining handlers to assert
that an inbound message is a full http message. Additionally it removes
the tests for chunked content.
    @Tim-Brooks
    Tim-Brooks committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    5d3e23a View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2018

  1. Change assertion messages

    @Tim-Brooks
    Tim-Brooks committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    0eda28a View commit details
    Browse the repository at this point in the history