-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Delete Snapshot High Level REST API #31393
Add Delete Snapshot High Level REST API #31393
Conversation
With this commit we add the delete snapshot API to the Java high level REST client. Relates elastic#27205
Pinging @elastic/es-core-infra |
@danielmitterdorfer you can use the low level rest API in the tests, and then change them once the high level API is done. This is what I did when implementing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great PR, quite nice to review. Just fyi, running the doc build shows that there are failures to the docs. LGTM for the most part, once the test is impl'd and the docs build is fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a small comment as well
* @return the response | ||
* @throws IOException in case there is a problem sending the request or parsing back the response | ||
*/ | ||
public DeleteSnapshotResponse deleteSnapshot(DeleteSnapshotRequest deleteSnapshotRequest, RequestOptions options) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you call these methods delete without the snapshot part? they will be called as client.snapshot().delete() then which is how they are defined in our SPEC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I've changed it.
@hub-cap I've implemented the tests now based on the low-level client as per your suggestion and fixed the doc issues. Can you please have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Doh that was supposed to be a not a 🚢 |
Both icons work for me. ;) Thanks for the review! |
Backported to 6.x in 71b3ac2. |
With this commit we add the delete snapshot API to the Java high level
REST client.
Relates #27205