Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add note about removing prepareExecute from the java client #31401

Merged
merged 2 commits into from
Jun 19, 2018
Merged

Docs: Add note about removing prepareExecute from the java client #31401

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cee41e
Docs: Add note about removing prepareExecute from the java client
rjernst Jun 18, 2018
1c1a156
fix typo
rjernst Jun 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/reference/migration/migrate_7_0/java.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,10 @@

`isShardsAcked` has been replaced by `isShardsAcknowledged` in
`CreateIndexResponse`, `RolloverResponse` and
`CreateIndexClusterStateUpdateResponse`.
`CreateIndexClusterStateUpdateResponse`.

==== `prepareExecute` removed from the client api

The `prepareExecute` method which created a request builder has been
removed from the client api. Instead, construct a build for the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this should be "builder" here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prepareExecute method returned a RequestBuilder. Is there something else you think it should be?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I see what you mean, thanks!

appropriate request directly.