Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logging breaking changes from 5.3 to 6.0 #31583

Merged
merged 1 commit into from
Jun 27, 2018

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Jun 26, 2018

logging related system properties were changed in logging between
5.2 and 5.3. Existing es.logs system property was deprecated in
5.x, and removed in 6.0.

This adds the logging breaking change to 6.0 list: https://www.elastic.co/guide/en/elasticsearch/reference/5.3/breaking-changes-5.3.html#_logging_configuration

logging related system properties were changed in logging between
5.2 and 5.3. Existing `es.logs` system property was deprecated in
5.x, and removed in 6.0.
@talevy talevy added >docs General docs changes review :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v6.4.0 labels Jun 26, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@talevy
Copy link
Contributor Author

talevy commented Jun 26, 2018

thanks for bringing this to our attention @jpcarey!

@jasontedor jasontedor added :Core/Infra/Logging Log management and logging utilities >breaking and removed :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts labels Jun 27, 2018
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@talevy
Copy link
Contributor Author

talevy commented Jun 27, 2018

Thanks @jasontedor! I definitely plagiarized your words here 😄

@talevy talevy merged commit c751779 into elastic:6.x Jun 27, 2018
@talevy talevy deleted the docs-logging-breaking-6 branch June 27, 2018 05:13
dnhatn added a commit that referenced this pull request Jun 28, 2018
* 6.x:
  Docs: Remove duplicate test setup
  Docs: Fix description of percentile ranks example example (#31652)
  Remove deprecation warnings to prepare for Gradle 5 (sourceSets.main.output.classesDirs) (#30389)
  Do not check for Azure container existence (#31617)
  Merge AwsS3Service and InternalAwsS3Service in a S3Service class (#31580)
  Remove item listed in 6.3 notes that's not in 6.3 (#31623)
  remove unused import
  Upgrade gradle wrapper to 4.8 (#31525)
  Only set vm.max_map_count if greater than default (#31512)
  QA: Merge query-builder-bwc to restart test (#30979)
  Docs: Skip xpack snippet tests if no xpack (#31619)
  [TEST] Fix RemoteClusterConnectionTests
  Remove legacy MetaDataStateFormat (#31603)
  [TEST] call yaml client close method from test suite (#31591)
  [TEST] Close additional clients created while running yaml tests (#31575)
  Node selector per client rather than per request (#31471)
  Preserve thread context when connecting to remote cluster (#31574)
  Remove redundant 'minimum_should_match'
  Unify headers for full text queries
  JDBC driver prepared statement set* methods  (#31494)
  add logging breaking changes from 5.3 to 6.0 (#31583)
  Fix a formatting issue in the docvalue_fields documentation. (#31563)
  Improve robustness of geo shape parser for malformed shapes
  QA: Create xpack yaml features (#31403)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Core/Infra/Logging Log management and logging utilities >docs General docs changes v6.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants