-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy MetaDataStateFormat #31603
Changes from 3 commits
c7011a6
ec76043
88eac6f
649f2f2
da6350b
ba97446
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,16 +81,16 @@ protected Settings prepareBackwardsDataDir(Path backwardsIndex) throws IOExcepti | |
return builder.build(); | ||
} | ||
|
||
public void testUpgradeStartClusterOn_0_20_6() throws Exception { | ||
String indexName = "unsupported-0.20.6"; | ||
public void testUpgradeStartClusterOn_2_4_5() throws Exception { | ||
String indexName = "unsupported-2.4.5"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are any of the other There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not as far as I can see (running the tests will confirm). I initially wanted to remove those in a follow-up, but I think we can do it as well in this PR. |
||
|
||
logger.info("Checking static index {}", indexName); | ||
Settings nodeSettings = prepareBackwardsDataDir(getBwcIndicesPath().resolve(indexName + ".zip")); | ||
try { | ||
internalCluster().startNode(nodeSettings); | ||
fail(); | ||
} catch (Exception ex) { | ||
assertThat(ex.getCause().getCause().getMessage(), containsString(" was created before v2.0.0.beta1 and wasn't upgraded")); | ||
assertThat(ex.getCause().getCause().getMessage(), containsString("Format version is not supported")); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure, fixed in 649f2f2 |
||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except we didn't ignore it, we returned
null
straight away...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
details ;)