-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EC2 credential test for repository-s3 #31918
Merged
vladimirdolzhenko
merged 15 commits into
elastic:master
from
vladimirdolzhenko:26913_ec2_credentials_test
Jul 18, 2018
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0278c88
add EC2 credential test
a56d1cd
excluded ec2_credentials from minio tests
5fe4227
some gradle amendments on Alpar's review
30e86c8
changes due to David's review: use own bucket/basepath for EC2 test; …
46dded9
clean AmazonS3Fixture from hard-coded keys
ccfa0c5
added s3EC2ProfileName to gradle; added nonAuthPath / authPath to Ama…
c7af0b6
polish of AmazonS3Fixture
0d31887
Merge remote-tracking branch 'remotes/origin/master' into lazy_repo_init
fd28579
moved to properties file for s3Fixture
4006d19
Merge remote-tracking branch 'remotes/origin/master' into 26913_ec2_c…
a4b3613
fix s3FixtureProperties generation
9c4c3e7
make fixture random again
5430473
some code improvements
0ffae39
Merge remote-tracking branch 'remotes/origin/master' into 26913_ec2_c…
161deee
(hopefully) final polish of AmazonS3Fixture
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be removed, the map is already initialized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, map is
null
, here is the output if I drop this line:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, this class initializes in the constructor, this is ok as it is.