Changed ReindexRequest to use Writeable.Reader #32401

sohaibiftikhar · 2018-07-26T14:28:05Z

-- This is a pre-stage for adding the reindex API to the REST high-level-client
-- Follows the pattern set in #26315

nik9000

Looks right to me.

@elastisticmachine, whitelist this please

nik9000 · 2018-07-26T15:32:25Z

white list this please

nik9000 · 2018-07-26T15:44:46Z

add to whitelist

…as well

sohaibiftikhar · 2018-07-26T17:41:16Z

server/src/main/java/org/elasticsearch/index/reindex/ReindexRequest.java

@@ -59,6 +59,13 @@ private ReindexRequest(SearchRequest search, IndexRequest destination, boolean s
        this.destination = destination;
    }

+    public ReindexRequest(StreamInput in) throws IOException {
+        super.readFrom(in);


@nik9000 Is this alright or should we do it also for the whole chain?

If doing the whole chain makes the PR too big, I'd do this. IT should be fine. If the PR isn't too big then I'd do the whole chain.

It does make it kind of complicated cause the chain is rather long. For now, I will leave it like this.

I was going to comment on this, but I understand how much this blows things up. So punting it sounds good!

elasticmachine · 2018-07-27T07:41:13Z

Pinging @elastic/es-core-infra

sohaibiftikhar · 2018-07-30T21:34:35Z

@nik9000 Could you have a look again when you have time?

nik9000 · 2018-07-30T22:13:39Z

@nik9000 Could you have a look again when you have time?

Sorry! I was distracted with something else. I'll look more closely in the morning. Which is kind of your afternoon. Sorry!

nik9000

This looks right to me. Maybe @talevy should look too because he knows this process better than I do. If he doesn't get a chance to review it by sometime tomorrow I'll give it another look and probably merge it.

talevy · 2018-07-31T01:59:45Z

thanks @sohaibiftikhar!

-- This is a pre-stage for adding the reindex API to the REST high-level-client -- Follows the pattern set in #26315

elasticmachine · 2018-07-31T14:39:20Z

Pinging @elastic/es-distributed

* master: Logging: Make node name consistent in logger (#31588) Mute SSLTrustRestrictionsTests on JDK 11 Increase max chunk size to 256Mb for repo-azure (#32101) Docs: Fix README upgrade mention (#32313) Changed ReindexRequest to use Writeable.Reader (#32401) Mute KerberosAuthenticationIT Fix AutoIntervalDateHistogram.testReduce random failures (#32301) fix no=>not typo (#32463) Mute QueryProfilerIT#testProfileMatchesRegular() HLRC: Add delete watch action (#32337) High-level client: fix clusterAlias parsing in SearchHit (#32465) Fix calculation of orientation of polygons (#27967) [Kerberos] Add missing javadocs (#32469) [Kerberos] Remove Kerberos bootstrap checks (#32451) Make get all app privs requires "*" permission (#32460) Switch security to new style Requests (#32290) Switch security spi example to new style Requests (#32341) Painless: Add PainlessConstructor (#32447) update rollover to leverage write-alias semantics (#32216) Update Fuzzy Query docs to clarify default behavior re max_expansions (#30819) INGEST: Clean up Java8 Stream Usage (#32059) Ensure KeyStoreWrapper decryption exceptions are handled (#32464)

@throws

* 6.x: Fix scriptdocvalues tests with dates Correct minor typo in explain.asciidoc for HLRC Fix painless whitelist and warnings from backporting #31441 Build: Add elastic maven to repos used by BuildPlugin (#32549) Scripting: Conditionally use java time api in scripting (#31441) [ML] Improve error when no available field exists for rule scope (#32550) [ML] Improve error for functions with limited rule condition support (#32548) [ML] Remove multiple_bucket_spans [ML] Fix thread leak when waiting for job flush (#32196) (#32541) Painless: Clean Up PainlessField (#32525) Add @AwaitsFix for #32554 Remove broken @link in Javadoc Add AwaitsFix to failing test - see #32546 SQL: Added support for string manipulating functions with more than one parameter (#32356) [DOCS] Reloadable Secure Settings (#31713) Fix compilation error introduced by #32339 [Rollup] Remove builders from TermsGroupConfig (#32507) Use hostname instead of IP with SPNEGO test (#32514) Switch x-pack rolling restart to new style Requests (#32339) [DOCS] Small fixes in rule configuration page (#32516) Painless: Clean up PainlessMethod (#32476) SQL: Add test for handling of partial results (#32474) Docs: Add missing migration doc for logging change Build: Remove shadowing from benchmarks (#32475) Docs: Add all JDKs to CONTRIBUTING.md Logging: Make node name consistent in logger (#31588) High-level client: fix clusterAlias parsing in SearchHit (#32465) REST high-level client: parse back _ignored meta field (#32362) backport fix of reduceRandom fix (#32508) Add licensing enforcement for FIPS mode (#32437) INGEST: Clean up Java8 Stream Usage (#32059) (#32485) Improve the error message when an index is incompatible with field aliases. (#32482) Mute testFilterCacheStats Scripting: Fix painless compiler loader to know about context classes (#32385) [ML][DOCS] Fix typo applied_to => applies_to Mute SSLTrustRestrictionsTests on JDK 11 Changed ReindexRequest to use Writeable.Reader (#32401) Increase max chunk size to 256Mb for repo-azure (#32101) Mute KerberosAuthenticationIT fix no=>not typo (#32463) HLRC: Add delete watch action (#32337) Fix calculation of orientation of polygons (#27967) [Kerberos] Add missing javadocs (#32469) Fix missing JavaDoc for @throws in several places in KerberosTicketValidator. Make get all app privs requires "*" permission (#32460) Ensure KeyStoreWrapper decryption exceptions are handled (#32472) update rollover to leverage write-alias semantics (#32216) [Kerberos] Remove Kerberos bootstrap checks (#32451) Switch security to new style Requests (#32290) Switch security spi example to new style Requests (#32341) Painless: Add PainlessConstructor (#32447) Update Fuzzy Query docs to clarify default behavior re max_expansions (#30819) Remove > from Javadoc (fatal with Java 11) Tests: Fix convert error tests to use fixed value (#32415) IndicesClusterStateService should replace an init. replica with an init. primary with the same aId (#32374) auto-interval date histogram - 6.x backport (#32107) [CI] Mute DocumentSubsetReaderTests testSearch [TEST] Mute failing InternalEngineTests#testSeqNoAndCheckpoints TEST: testDocStats should always use forceMerge (#32450) TEST: Avoid deletion in FlushIT AwaitsFix IndexShardTests#testDocStats Painless: Add method type to method. (#32441) Remove reference to non-existent store type (#32418) [TEST] Mute failing FlushIT test Fix ordering of bootstrap checks in docs (#32417) Wrong discovery.type for azure in breaking changes (#32432) Mute ConvertProcessorTests failing tests TESTS: Move netty leak detection to paranoid level (#32354) (#32425) Upgrade to Lucene-7.5.0-snapshot-608f0277b0 (#32390) [Kerberos] Avoid vagrant update on precommit (#32416) TEST: Avoid triggering merges in FlushIT [DOCS] Fixes formatting of scope object in job resource Switch x-pack/plugin to new style Requests (#32327) Release requests in cors handle (#32410) Remove BouncyCastle dependency from runtime (#32402) Copy missing segment attributes in getSegmentInfo (#32396) Rest HL client: Add put license action (#32214) Docs: Correcting a typo in tophits (#32359) Build: Stop double generating buildSrc pom (#32408) Switch x-pack full restart to new style Requests (#32294) Painless: Clean Up PainlessClass Variables (#32380) [ML] Consistent pattern for strict/lenient parser names (#32399) Add Restore Snapshot High Level REST API Update update-settings.asciidoc (#31378) Introduce index store plugins (#32375) Rank-Eval: Reduce scope of an unchecked supression Make sure _forcemerge respects `max_num_segments`. (#32291)

* ccr: (24 commits) Remove _xpack from CCR APIs (elastic#32563) TEST: Avoid merges in testRecoveryWithOutOfOrderDelete Logging: Make node name consistent in logger (elastic#31588) Mute SSLTrustRestrictionsTests on JDK 11 Increase max chunk size to 256Mb for repo-azure (elastic#32101) Docs: Fix README upgrade mention (elastic#32313) Changed ReindexRequest to use Writeable.Reader (elastic#32401) Mute KerberosAuthenticationIT Fix AutoIntervalDateHistogram.testReduce random failures (elastic#32301) fix no=>not typo (elastic#32463) Mute QueryProfilerIT#testProfileMatchesRegular() HLRC: Add delete watch action (elastic#32337) High-level client: fix clusterAlias parsing in SearchHit (elastic#32465) Fix calculation of orientation of polygons (elastic#27967) [Kerberos] Add missing javadocs (elastic#32469) [Kerberos] Remove Kerberos bootstrap checks (elastic#32451) Make get all app privs requires "*" permission (elastic#32460) Switch security to new style Requests (elastic#32290) Switch security spi example to new style Requests (elastic#32341) Painless: Add PainlessConstructor (elastic#32447) ...

Changed Reindex request to use Writeable.Reader

f73202f

sohaibiftikhar changed the title ~~Changed ReindexRequest to use revamped TransportRequest~~ Changed ReindexRequest to use Writeable.Reader Jul 26, 2018

sohaibiftikhar mentioned this pull request Jul 26, 2018

Changed Reindex request to use Writeable.Reader (6.x) #32404

Closed

1 task

nik9000 approved these changes Jul 26, 2018

View reviewed changes

fixed tests. todo: do the change for update/delete by query requests …

c9906ef

…as well

sohaibiftikhar commented Jul 26, 2018

View reviewed changes

Added Writeable.Reader support for {Delete,Update}ByQueryRequest

948cbfb

colings86 added the :Data Management/Indices APIs APIs to create and manage indices and templates label Jul 27, 2018

nik9000 approved these changes Jul 30, 2018

View reviewed changes

talevy approved these changes Jul 31, 2018

View reviewed changes

nik9000 added v7.0.0 v6.5.0 >non-issue labels Jul 31, 2018

nik9000 merged commit 4fa92cb into elastic:master Jul 31, 2018

nik9000 pushed a commit that referenced this pull request Jul 31, 2018

Changed ReindexRequest to use Writeable.Reader (#32401)

6486cdf

-- This is a pre-stage for adding the reindex API to the REST high-level-client -- Follows the pattern set in #26315

nik9000 added :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. and removed :Data Management/Indices APIs APIs to create and manage indices and templates labels Jul 31, 2018

colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed ReindexRequest to use Writeable.Reader #32401

Changed ReindexRequest to use Writeable.Reader #32401

sohaibiftikhar commented Jul 26, 2018

nik9000 left a comment

nik9000 commented Jul 26, 2018

nik9000 commented Jul 26, 2018

sohaibiftikhar Jul 26, 2018

nik9000 Jul 26, 2018

sohaibiftikhar Jul 26, 2018

talevy Jul 31, 2018

elasticmachine commented Jul 27, 2018

sohaibiftikhar commented Jul 30, 2018

nik9000 commented Jul 30, 2018

nik9000 left a comment

talevy commented Jul 31, 2018

elasticmachine commented Jul 31, 2018

Changed ReindexRequest to use Writeable.Reader #32401

Changed ReindexRequest to use Writeable.Reader #32401

Conversation

sohaibiftikhar commented Jul 26, 2018

nik9000 left a comment

Choose a reason for hiding this comment

nik9000 commented Jul 26, 2018

nik9000 commented Jul 26, 2018

sohaibiftikhar Jul 26, 2018

Choose a reason for hiding this comment

nik9000 Jul 26, 2018

Choose a reason for hiding this comment

sohaibiftikhar Jul 26, 2018

Choose a reason for hiding this comment

talevy Jul 31, 2018

Choose a reason for hiding this comment

elasticmachine commented Jul 27, 2018

sohaibiftikhar commented Jul 30, 2018

nik9000 commented Jul 30, 2018

nik9000 left a comment

Choose a reason for hiding this comment

talevy commented Jul 31, 2018

elasticmachine commented Jul 31, 2018