CORE: Upgrade to Jackson 2.8.11 #32670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original-brownbear
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
|
@jasontedor thanks! |
@original-brownbear I'm just pointing you to #27032 which contains some issues I saw with Jackson 2.9.x. If you test the upgrade you might want to have a look at them and check if they are still valid issues or not. |
|
@tlrx thanks. Looks like at least FasterXML/jackson-dataformats-text#90 is still open though :( So |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 8, 2018
original-brownbear
added a commit
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.8.11.2because that was not available for all Jackson modules we use, this version does fix the issue mentioned in Update Jackson version to 2.8.11.2 #30352 as well though and we can probably just move to2.9.xat some point instead of complicating the build for this.