Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CharArrays to core lib #32851

Merged
merged 3 commits into from
Aug 15, 2018
Merged

Move CharArrays to core lib #32851

merged 3 commits into from
Aug 15, 2018

Conversation

jaymode
Copy link
Member

@jaymode jaymode commented Aug 14, 2018

This change cleans up some methods in the CharArrays class from x-pack, which
includes the unification of char[] to utf8 and utf8 to char[] conversions that
intentionally do not use strings. There was previously an implementation in
x-pack and in the reloading of secure settings. The method from the reloading
of secure settings was adopted as it handled more scenarios related to the
backing byte and char buffers that were used to perform the conversions. The
cleaned up class is moved into libs/core to allow it to be used by requests
that will be migrated to the high level rest client.

Relates #32332

This change cleans up some methods in the CharArrays class from x-pack, which
includes the unification of char[] to utf8 and utf8 to char[] conversions that
intentionally do not use strings. There was previously an implementation in
x-pack and in the reloading of secure settings. The method from the reloading
of secure settings was adopted as it handled more scenarios related to the
backing byte and char buffers that were used to perform the conversions. The
cleaned up class is moved into libs/core to allow it to be used by requests
that will be migrated to the high level rest client.

Relates elastic#32332
@jaymode jaymode added >non-issue v7.0.0 :Security/Security Security issues without another label v6.5.0 labels Aug 14, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for taking care of this!

@jaymode jaymode merged commit 1a45b27 into elastic:master Aug 15, 2018
@jaymode jaymode deleted the move_char_arrays branch August 15, 2018 21:26
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Aug 15, 2018
jaymode added a commit that referenced this pull request Aug 15, 2018
This change cleans up some methods in the CharArrays class from x-pack, which
includes the unification of char[] to utf8 and utf8 to char[] conversions that
intentionally do not use strings. There was previously an implementation in
x-pack and in the reloading of secure settings. The method from the reloading
of secure settings was adopted as it handled more scenarios related to the
backing byte and char buffers that were used to perform the conversions. The
cleaned up class is moved into libs/core to allow it to be used by requests
that will be migrated to the high level rest client.

Relates #32332
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Aug 24, 2018
…-checkpoint-poll

* 'master' of github.com:elastic/elasticsearch:
  Fix docs for fixed filename for heap dump path (elastic#32882)
  Painless: Special Case def (elastic#32871)
  AwaitFix FullClusterRestartIT#testRollupIDSchemeAfterRestart.
  [Test] Fix DuelScrollIT#testDuelIndexOrderQueryThenFetch
  HLRC: adding machine learning delete job (elastic#32820)
  [DOCS] Update WordPress plugins links (elastic#32194)
  Remove passphrase support from reload settings API (elastic#32889)
  AwaitFix AckIT.
  Mutes test in DuelScrollIT
  CharArraysTests: Fix test bug.
  [ML] Choose seconds to fix intermittent DatafeeedConfigTest failure
  Test: Fix unpredictive merges in DocumentSubsetReaderTests
  [DOCS] Clarify sentence in network-host.asciidoc (elastic#32429)
  Docs enhancement: added reference to cluster-level setting `search.default_allow_partial_results` (elastic#32810)
  [DOCS] Fixing cross doc link to Stack Overview security topic.
  Move CharArrays to core lib (elastic#32851)
  Fix global checkpoint listeners test
  HLRC: adding machine learning open job (elastic#32860)
  [ML] Add log structure finder functionality (elastic#32788)
  INGEST: Add Configuration Except. Data to Metdata (elastic#32322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants