DOCS: Make ellipsis optional in /cat/thread_pool #33186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix proposed in elastic#31442 fails with the oss distro because the added 3dots does not match anything with the default oss while a 3dots expression requires matching at least one thread pool. This change adjusts the thread pool list so that it can match both the oss (without ccr) and default distro (with ccr).
dnhatn
added
>feature
>docs
|
Pinging @elastic/es-distributed |
jasontedor
reviewed
Aug 27, 2018
| @@ -16,10 +16,11 @@ Which looks like: | |||
| -------------------------------------------------- | |||
| node-0 analyze 0 0 0 | |||
| ... | |||
There was a problem hiding this comment.
Hmm...I was thinking instead we should make the ... translate to an optional pattern that would match the specified thread pool format (node-\d+ \S+ \d+ \d+ \d+). That way we do not have to require there be a thread pool between analyze and fetch_shard_started.
This reverts commit dca38d6.
dnhatn
changed the title
|
@jasontedor Yep, I've made 3dots optional! |
|
Thanks @jasontedor for reviewing! |
dnhatn
added a commit
that referenced
this pull request
Aug 27, 2018
The fix proposed in #31442 fails with the oss distro because the added 3dots does not match anything with the default oss while a 3dots expression requires matching at least one thread pool. This change makes an ellipsis optional so the thread_pool list can match both the oss distro (without ccr) and default distro (with ccr). Relates #31442
dnhatn
changed the title
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Aug 27, 2018
* ccr: DOCS: Make ellipsis optional in /cat/thread_pool (elastic#33186)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix proposed in #31442 fails with the oss distro because the added
3dots does not match anything with the default oss while a 3dots
expression requires matching at least one thread pool.
This change makes a 3dots optional so the thread_pool list can match
both the oss distro (without ccr) and default distro (with ccr).
Relates #31442