Add nested and object fields to field capabilities response #33803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds nested and object fields to the field capabilities response. Closes elastic#33237
jimczi
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search-aggs |
|
\cc @costin |
|
FTR, I've used this PR in SQL and it behaved as expected. |
jpountz
approved these changes
Sep 25, 2018
| while (dotIndex > -1) { | ||
| String parentField = ft.name().substring(0, dotIndex); | ||
| ObjectMapper mapper = mapperService.getObjectMapper(parentField); | ||
| if (mapper != null) { |
There was a problem hiding this comment.
I was wondering whether this condition may ever be false, maybe mention sub fields in a comment? Should we also break as soon as responseMap.containsKey(parentField) is true?
There was a problem hiding this comment.
Should we also break as soon as responseMap.containsKey(parentField) is true?
If we start from the leaf, yes, I pushed
235df36 to reverse the iteration order.
jimczi
added a commit
that referenced
this pull request
Sep 26, 2018
This commit adds nested and object fields to the field capabilities response. Closes #33237
costin
added a commit
to costin/elasticsearch
that referenced
this pull request
Oct 22, 2018
Extend querying support on multiple indices from being strictly identical to being just compatible. Use FieldCapabilities API (extended through elastic#33803) for mapping merging. Close elastic#31837 elastic#31611
This was referenced Oct 22, 2018
costin
added a commit
that referenced
this pull request
Oct 23, 2018
costin
added a commit
that referenced
this pull request
Oct 23, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This commit adds nested and object fields to the field capabilities response. Closes #33237
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds nested and object fields to the field capabilities response.
Closes #33237