Amazon plugins: Wrap at 140 columns #34495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies our standard column wrapping to the `discovery-ec2` and `repository-s3` plugins.
nik9000
changed the title
nik9000
added
>non-issue
:Distributed Coordination/Discovery-Plugins
|
Pinging @elastic/es-distributed |
nik9000
commented
Oct 15, 2018
| @@ -143,12 +143,14 @@ public void setS3ClientOptions(S3ClientOptions clientOptions) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void changeObjectStorageClass(String bucketName, String key, StorageClass newStorageClass) throws AmazonClientException, AmazonServiceException { | |||
There was a problem hiding this comment.
This file and its brother below are huge and we might be able to use mockito for it now but I didn't want to make a big change to how the test was implemented. And I was on an airplane and this is the kind of thing you do when you are tired and bored on an airplane. I'd be happy to be told "don't merge this, see about mockito instead" if anyone things that is a good idea.
nik9000
added a commit
that referenced
this pull request
Oct 18, 2018
Applies our standard column wrapping to the `discovery-ec2` and `repository-s3` plugins.
matriv
pushed a commit
to matriv/elasticsearch
that referenced
this pull request
Oct 19, 2018
Applies our standard column wrapping to the `discovery-ec2` and `repository-s3` plugins.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Applies our standard column wrapping to the `discovery-ec2` and `repository-s3` plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies our standard column wrapping to the
discovery-ec2andrepository-s3plugins.