Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Zen2] Update documentation for Zen2 #34714
[Zen2] Update documentation for Zen2 #34714
Changes from 105 commits
621774a
56d050f
aa6df51
7c9db23
830eca7
d91c924
d03103a
c762dba
8ca2e75
d8ec40b
a498e42
eb0aa2f
ebcbe3c
27a9ffb
f43414d
1fef44e
10020db
05dc68a
529a94a
dd35159
40649bd
e88656c
697bbca
8de22f1
b54c0c1
cb38a39
dfd64f9
0973de8
e8d9656
208d463
de98cba
12c2b4b
d4763ee
09b6293
3fc691f
ca73f1f
01e7555
f3a8b93
e10d760
ff1e87c
024c9b2
02b607c
60d64b4
6102d5b
9fa0844
fb1e7d3
bfc7d16
2ed2c39
68d9ef5
a2b4d38
bb6ef8e
cbd33ff
b91519c
7540e4e
d04b7ad
8635a41
1189440
7c7e7af
d48eccc
43a6dcc
e6087e9
02b7ebd
7714003
dddc3cf
1888c97
b8997b1
b1e98bd
a1c9843
4b40b34
e6b7401
041494c
f438a28
4180e00
76ec76c
8d1b118
2df3878
17be8bb
7ca6cc8
2fdb92f
c4fd335
1d69b0a
9003c04
771cf61
14de23c
58c2a52
98f1485
ebe1a1f
2cac91f
b4dd874
9d787f9
400b2e4
802a413
0ea5488
00a0145
9cdc18f
a9848ab
4b55b1e
6778c0a
b349806
ccba8ba
8835ef2
0643929
dea0d59
442a7a7
14194c6
e466ed0
8e34a77
ec4e739
f4a41db
6af3721
0b2b63c
f24c1d9
64564c0
852caed
94bc24b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be great to have the following example here. Consider you have 3 master eligible nodes - A, B, C and auto_shrink is set to true. In this case, the voting configuration will be {A, B, C}. Now consider node C fails, the voting configuration is not changed in this case, because there would be less than 3 nodes if node C is removed. Now master-eligible node D connects to the cluster, in this case, node C will be atomically replaced with node D in the voting configuration - {A, B, D}.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should wait and see about this. I am worried that introducing this one example will raise more questions than it answers, and do not want to introduce a much broader selection of examples. This particular example is spelled out here:
elasticsearch/server/src/test/java/org/elasticsearch/cluster/coordination/ReconfiguratorTests.java
Line 63 in a056bd8
However as you can see from that test case there are many other examples to think about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the majority of this information pertains only to removing nodes. It's not necessary immediately, but at some point I think it would be good to split this into two separate pages -- one about adding nodes (with lots of details about how that differs depending on platform and node type, etc) and one about removing nodes (which would be most of this content).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There just isn't really a lot to say about adding nodes in this context. I added headings to divide the page up in e466ed0.
This file was deleted.