Add support for storing JSON fields. #34942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
force-pushed
the
store-json-fields
branch
from
263e4cc to
90732e9
Compare
jtibshirani
force-pushed
the
store-json-fields
branch
4 times, most recently
from
7794870 to
59bd0ca
Compare
jtibshirani
added
>feature
:Search Foundations/Mapping
|
Pinging @elastic/es-search-aggs |
jtibshirani
commented
Oct 29, 2018
| if (fieldType().indexOptions() != IndexOptions.NONE) { | ||
| XContentParser indexedFieldsParser = context.parser(); | ||
|
|
||
| // If store is enabled, we've already consumed the content to produce the stored field. Here we |
There was a problem hiding this comment.
The alternative here would be to add logic to JsonFieldParser to generate the stored field as it's parsed. Although it avoids parsing the input twice as we do here, that approach turned turned out fairly messy and didn't separate out concerns as nicely. It also seems uncommon to enable stored fields, so I wasn't as concerned about the fact we will parse the input twice.
There was a problem hiding this comment.
I agree, I don't think its worth the complexity of trying to produce the stored field content in the same pass as the index field for the rare case that the field is stored.
11 tasks
jtibshirani
force-pushed
the
object-fields
branch
from
bb0884d to
a6d8a49
Compare
jtibshirani
force-pushed
the
store-json-fields
branch
from
59bd0ca to
5221f18
Compare
jtibshirani
added a commit
that referenced
this pull request
Oct 31, 2018
jtibshirani
added a commit
that referenced
this pull request
Nov 7, 2018
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Nov 8, 2018
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Nov 9, 2018
jtibshirani
added a commit
that referenced
this pull request
Nov 30, 2018
jtibshirani
added a commit
that referenced
this pull request
Dec 5, 2018
jtibshirani
added a commit
that referenced
this pull request
Dec 13, 2018
jtibshirani
added a commit
that referenced
this pull request
Mar 6, 2019
jtibshirani
added a commit
that referenced
this pull request
Mar 7, 2019
jtibshirani
added a commit
that referenced
this pull request
Mar 9, 2019
jtibshirani
added a commit
that referenced
this pull request
Mar 11, 2019
jtibshirani
added a commit
that referenced
this pull request
Mar 14, 2019
jtibshirani
added a commit
that referenced
this pull request
Mar 19, 2019
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Mar 19, 2019
jtibshirani
added a commit
that referenced
this pull request
Mar 28, 2019
jtibshirani
added a commit
that referenced
this pull request
Apr 10, 2019
jtibshirani
added a commit
that referenced
this pull request
Apr 17, 2019
jtibshirani
added a commit
that referenced
this pull request
May 1, 2019
jtibshirani
added a commit
that referenced
this pull request
May 24, 2019
jtibshirani
added a commit
that referenced
this pull request
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 'store' is enabled, a single stored field is added containing the entire JSON object in pretty-printed format.